Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3026852ybt; Mon, 29 Jun 2020 13:15:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrPiWNDzr/PNzHnS/dYK/6kzqDfMqoTy/vHT113YnxXYQNOpHkN4hvD4CJZxXzzJXmXMM5 X-Received: by 2002:a17:906:c10f:: with SMTP id do15mr16214134ejc.249.1593461759483; Mon, 29 Jun 2020 13:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593461759; cv=none; d=google.com; s=arc-20160816; b=dwLc09ie5wFE/iBPKdM7BJTVkTBWx9GSkKL/Y8ZgwXe57eyoiPwj0A5xbeoo60SkWx oMJvyVLW10lvBrTn+831eqAeJGm8IXOvACwUtBxoXPglDGFZoP2fzFy8N4DfQPzJGzDJ VNdXCtWkkS0udH7pL2yeE4MO+59KArQcDdtFcfugIo0ZxG3PC4Giyo51YXAuhE6809mN +7JwP5nmgCxiO7Wi5FBklGbUx24ZJSvs0alglanxoZeHFQfBU/Tg8BFJR3RoVREHFXCA KAVfJnIoGFFmSPi3Q4RN1U9qsAtSlUL4Qxo7ZQZXcSljY/95qqr4A4I2/853pOwV4egX P6nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0TxoYk5VipeuSU/zqVtuueFuLUCfXqOYAmRHeleXugM=; b=FaN9N1zMHBkBRBJtnIqb29Ul0reHtrdswT4UminuwkiAq7OCSXuPKhyKDTnVturL0A f5LFsxxl3N54cAVvIiFJYg0PsVK5TY/kHY6xfgmdbRGrEzxHOOZdaTHVaEIzOhT+gAGb yVWDCZB5+umCcShTuCBJWd3RAf8mTulwXCXchY7QzvM5svEf6H8P3dKHCndvrAzMjcuo wUN/aswdrLhqBUUpcYszf0R2jp4v1VLn2i5dYPW+dn8DVrq2+bIqykRjJegWKmurmqqJ agAuKOlUoJbz1uvDgxuSwtaF4q9GHvlz7rK44gjc+JwcedluOffaorFJYvIfc5IyXkOf WBnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nA6foVKI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si301813edn.530.2020.06.29.13.15.36; Mon, 29 Jun 2020 13:15:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nA6foVKI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732352AbgF2UOK (ORCPT + 99 others); Mon, 29 Jun 2020 16:14:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:40592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732849AbgF2TaT (ORCPT ); Mon, 29 Jun 2020 15:30:19 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 204D9252BD; Mon, 29 Jun 2020 15:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593445030; bh=xJLQ0boay0Bf+EKvPVKaRb97JxMWn1YRifhIR045NQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nA6foVKI2Q4Ub97PC3+qsReOgBe/XQ9cRNgzSQFBT0oHMYWnh8Co0MKcod3qXTJCt Pd/NRXHf0UYCrYGJDK6GCvt9ManbgvfxhL6ooAhJZGXTK51cxXTabAhHFow7NcRdab 9pfbATfaSLcmKH31IioFcu1Wcq1MHv4n3Zh5P8cQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Huaisheng Ye , Mikulas Patocka , Mike Snitzer , Greg Kroah-Hartman Subject: [PATCH 4.19 128/131] dm writecache: correct uncommitted_block when discarding uncommitted entry Date: Mon, 29 Jun 2020 11:34:59 -0400 Message-Id: <20200629153502.2494656-129-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629153502.2494656-1-sashal@kernel.org> References: <20200629153502.2494656-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.131-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.19.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.19.131-rc1 X-KernelTest-Deadline: 2020-07-01T15:34+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huaisheng Ye commit 39495b12ef1cf602e6abd350dce2ef4199906531 upstream. When uncommitted entry has been discarded, correct wc->uncommitted_block for getting the exact number. Fixes: 48debafe4f2fe ("dm: add writecache target") Cc: stable@vger.kernel.org Signed-off-by: Huaisheng Ye Acked-by: Mikulas Patocka Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-writecache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index 4321c48eba6b9..509552fc55fc7 100644 --- a/drivers/md/dm-writecache.c +++ b/drivers/md/dm-writecache.c @@ -811,6 +811,8 @@ static void writecache_discard(struct dm_writecache *wc, sector_t start, sector_ writecache_wait_for_ios(wc, WRITE); discarded_something = true; } + if (!writecache_entry_is_committed(wc, e)) + wc->uncommitted_blocks--; writecache_free_entry(wc, e); } -- 2.25.1