Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3035653ybt; Mon, 29 Jun 2020 13:31:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJRgAUilVHJp/jlu9LF1I2P1l8D2+pf4+rZNCSDeHzVSw/caS+bAyNs9mGZRl4NUPca6no X-Received: by 2002:a50:d1c2:: with SMTP id i2mr19067495edg.42.1593462700211; Mon, 29 Jun 2020 13:31:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593462700; cv=none; d=google.com; s=arc-20160816; b=0tCR6M8TSctu8JKHgus+dwIY4vDn17uTM4B1rwrkdEFroUD1YWKN+lY/INDthQX+0h ubCJcxsJeh/OIDJlhLHiKd6CQOgtUlRSpWughgvC64d5NF+f75OpB4lUI3tIvq8xbave rjwNZTz5XH8CA/tHtH4UyGWTlZph3UeVD1FeABFoeQ4AUwiu0hMUkK/4MuUyu/gEAPA3 ObD5P+5xP65zNCKhRyZqj37JMRSAU70D/chW2RAsIyaancHb9HSjn1zP0bLeN9kXiQkO jA0YDKxwQWe6I99UkU86lVvfBnro/oqfu7vdVhsJNAEZxnIi8rKaie6slsaDhniQA+iu 83IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=M+y/aDt4GZNMD+zmQOgCu7ZRDkoDQErE/X0dgFBdNq8=; b=Gi8Vmr7wrHZa5OFL0BDF4BlP+mef1PrgqctAEoF60iA+6RjfK2/W27Fj/AZ4oUgBtE ji2xh8EUG0ajqSCqKqQToCZ9OJj5+g67DI3DZ2GCiSCFkMCHeyWMKfSyzd96OhjR6Eg0 FHCXM6ew9uifEwlFhH/eLtvB/PpzT+pU9IHi7LWGZ7iyw1mDvXx78O9ejV/A2TPihTzt h1QqlQhUoF+ppXRU9T3PYObvecFmYKO3L59k/iii7WpRs52CLFJ/0cGtwFvi/rujskdC ru2ku6UiBZOUbebHH00nZc3MzzMv4Z+16tAtAWbuLc4sXwLD2fKCw0nxU71t3mxeaMPf Xzcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=raznR2xH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c9si386089ejx.552.2020.06.29.13.31.17; Mon, 29 Jun 2020 13:31:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=raznR2xH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389177AbgF2U2E (ORCPT + 99 others); Mon, 29 Jun 2020 16:28:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:37038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732505AbgF2TZY (ORCPT ); Mon, 29 Jun 2020 15:25:24 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 68C632538B; Mon, 29 Jun 2020 15:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593445255; bh=O8OnCYgvR9JOBs3QiGMTB91I6sGqjaXgtjIc0MOs+Fk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=raznR2xHZwcltQmBPkdfePy+oJoNxCvz5DLAwdyM0abBXFZllEcOCDjT9eboDn3en /alQr2FR2cWCvn2scYsoERMpaqJThf0LUFERBW5xmVBRiH7gW2r8kAzChK2asFVZyK pUkMLSmPAtlKNnAqoAtlhTB8ACRW4AANY65qo6b0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Suganath Prabu S , Dan Carpenter , "Martin K . Petersen" , Sasha Levin Subject: [PATCH 4.9 037/191] scsi: mpt3sas: Fix double free warnings Date: Mon, 29 Jun 2020 11:37:33 -0400 Message-Id: <20200629154007.2495120-38-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629154007.2495120-1-sashal@kernel.org> References: <20200629154007.2495120-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.9.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.9.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:39+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suganath Prabu S [ Upstream commit cbbfdb2a2416c9f0cde913cf09670097ac281282 ] Fix following warning from Smatch static analyser: drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->hpr_lookup' double freed drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->internal_lookup' double freed Link: https://lore.kernel.org/r/20200508110738.30732-1-suganath-prabu.subramani@broadcom.com Reported-by: Dan Carpenter Signed-off-by: Suganath Prabu S Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 6ccde2b415178..601a93953307d 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -3166,7 +3166,9 @@ _base_release_memory_pools(struct MPT3SAS_ADAPTER *ioc) ioc->scsi_lookup = NULL; } kfree(ioc->hpr_lookup); + ioc->hpr_lookup = NULL; kfree(ioc->internal_lookup); + ioc->internal_lookup = NULL; if (ioc->chain_lookup) { for (i = 0; i < ioc->chain_depth; i++) { if (ioc->chain_lookup[i].chain_buffer) -- 2.25.1