Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3037190ybt; Mon, 29 Jun 2020 13:34:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyol3pz70vsTYD8MaN4lT2lbrWb7yqjO+Day4GXmBgE9DcHlulUrX39zgpjobRdU70xkoz+ X-Received: by 2002:a17:906:fa9a:: with SMTP id lt26mr6228737ejb.502.1593462847944; Mon, 29 Jun 2020 13:34:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593462847; cv=none; d=google.com; s=arc-20160816; b=rV4uZ0rdjrKV06dy3oDgVQerc98ofAG1tccvDKcIFWqAHT2Hrmdym0cZ1c+Xi6apd+ nr2AAznP8LdYoy40hP8t5+a2sG2TBylHj01pkb9zpO6tSoBuemEa6Iz8GfAe9mBbXXyV RIzGaIPWXKNjA7kytSznaXFJv1Sq/sd5uYSx7sQ7WAPyplPfnIHRnC+Jn/q8r0fR5EoJ 10WMqHfAHxo1ZjkTJg7OmGpoSWNOGtvwJdgE9Wdxemc3qZdD6MTs7TAz5Qk6fzYoSyA0 yjMymKzoQmSrOAYlPBvKgzCZZtoeSyq55jBtWWC+KOBRRIA1jrDV/CZ0RZtCiREMC/3o Rh1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tef7cMdDN6ZORfN95fQ7r66mBVvJ4PKcKetl03rukTE=; b=P7LM9NXr4+5tFAOxR5jCgG3Htld3/REmfrj/YrhBFsZROlGwiZh5es7col+gSC+uQD PhPyIhoype0FRwckHZsEWmVj7XIjb5n2q2GvJY7+dZWAGU/Bb+V6DbJH98crxfDKAs5J na6wRmqhWyRcj9KM+zegXH7PIZNts80q6Y+z2Po82THCwiY5TS1Z/NdiXmHXhZYhv9bN /JHAvWxe9U2P0yps1VuQIgoWb2HUE5AAPJ189rV//7tC9tbvxZ8a7q86+7udB9YakMzx iBsAOGvoiEyf2pJgAjOEu5DhbT7yBJ8U/90hwzgtuZQ0w5wzHNpfcaLQ9tubN43Ke84I pjrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IZxtp2jQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi8si351277edb.602.2020.06.29.13.33.44; Mon, 29 Jun 2020 13:34:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IZxtp2jQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389291AbgF2UcY (ORCPT + 99 others); Mon, 29 Jun 2020 16:32:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:37026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732417AbgF2TZS (ORCPT ); Mon, 29 Jun 2020 15:25:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EECB25318; Mon, 29 Jun 2020 15:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593445146; bh=QQjTy83/bItqKgEe9rfd0Yx/TjTAlqto0VCLdCQMsCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IZxtp2jQY6bzSaWdhYyhZsU3UImWRUcT3YQ+Yh8T3VR+BagXF0qzrEIhW5/cV9cJx smM1rF4VvPsaMpVYJYv9q29gV1kX59q+XbCFQG96Lb6dDAwT7AroDOQB6I424p9tII 0PYk0WzW7KCH86MxExUC6MJMO994M6/eQ5nzmQrE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Felipe Balbi , Sasha Levin Subject: [PATCH 4.14 50/78] usb: gadget: udc: Potential Oops in error handling code Date: Mon, 29 Jun 2020 11:37:38 -0400 Message-Id: <20200629153806.2494953-51-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629153806.2494953-1-sashal@kernel.org> References: <20200629153806.2494953-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.186-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.14.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.14.186-rc1 X-KernelTest-Deadline: 2020-07-01T15:38+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit e55f3c37cb8d31c7e301f46396b2ac6a19eb3a7c ] If this is in "transceiver" mode the the ->qwork isn't required and is a NULL pointer. This can lead to a NULL dereference when we call destroy_workqueue(udc->qwork). Fixes: 3517c31a8ece ("usb: gadget: mv_udc: use devm_xxx for probe") Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/mv_udc_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index 4103bf7cf52ab..62fad60d0c061 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -2317,7 +2317,8 @@ static int mv_udc_probe(struct platform_device *pdev) return 0; err_create_workqueue: - destroy_workqueue(udc->qwork); + if (udc->qwork) + destroy_workqueue(udc->qwork); err_destroy_dma: dma_pool_destroy(udc->dtd_pool); err_free_dma: -- 2.25.1