Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3038117ybt; Mon, 29 Jun 2020 13:36:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynr6BN9rZSypEDck09eHje6aKVogEVpg5JEjhSe9rN5IPd6ZqO/mVk3Fpq+ZNg99TMHgrt X-Received: by 2002:a17:906:a2d7:: with SMTP id by23mr15188817ejb.226.1593462961101; Mon, 29 Jun 2020 13:36:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593462961; cv=none; d=google.com; s=arc-20160816; b=BQOotYeuKFUxKcNHwUxqcU0hnhAhSXkDk12EeEaQ4cbnYwPTB8W8LEID0Xe0gXj2XI lTphE26isBbUh776R5nIbj5/2GMIsSaoDORoeRVguA2hvlnZjwyHZmmMn6wU4dpejqXV rlJJk35sFpC5yclB9B7ArDSB3wy05Wl+JmxbttbzqJvdcUtiJcgkTLU0umEcG28gfUqt kfMhoMJmlyRwn5GwIdkwCyVHfegKASa9cZTS0Fnydqkel5GRqwWIYG2cMpJ+tNhjTB78 LzssIExkj8IdynUackHaBlJrMTfI7bvhBPQu6o4zWgFZ+tzn5vzZJwSHA2HUZfiAodr0 SKZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=C5Y+9ypnrFjvZ7UufFipH0L8cuXIpPUZWTBdwBNyV9A=; b=NbRcaQ4zAl0qQLJpjRHmbp5j25Rywrhb3A0ibd8A9h1c7FXNwEqBARZNdNXE656d5Z dDAFdof9Qce6vZUxVbhspjRCxTXbCyC0YDsKLz3xSfo4qf9V0IIz2SmnXZovUhuGMIxt fbktHVrDM873QS9yo9Xt7RobBmsMP682ujqfCA7VtKd5GfR0Vy4nEKb18U0fJHAGv45k ors8XQIe1fQ2udeR8FEFxuKXRudn/JrjpiVctGsUeZFYfKSSVp2K7TVaQ/H/jhJ9X1AD 5OC04mSnER26LHL71wjU6dDdvV7zr2GY3uv1XFx/u76N47WYxMLkDyfDeSwk0gJpb7ws WGAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="CtsNII7/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi8si305540edb.602.2020.06.29.13.35.38; Mon, 29 Jun 2020 13:36:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="CtsNII7/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389304AbgF2Uc3 (ORCPT + 99 others); Mon, 29 Jun 2020 16:32:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:37064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732445AbgF2TZS (ORCPT ); Mon, 29 Jun 2020 15:25:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D87F25415; Mon, 29 Jun 2020 15:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593445366; bh=1BjEz1tNYoNIeAeDoXRNi9H/EWV7Ubqa6oY+NfFIwu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CtsNII7/jzuADAaqSnxxtFqwDkbSAIhzVPfK0+QISE91JNAlYFIZ5Vj7tieyqH7OU XuY735oCBS1amdEk16KTzuYPeWNYZ2zyyrTJWlHetjHPZmYare+3kuchFUA+A6XBU1 g37Te8eSFkDbjMlixaAzDreNaci1pw9VnhsCL/bM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Miquel Raynal , Sasha Levin Subject: [PATCH 4.9 121/191] mtd: rawnand: sharpsl: Fix the probe error path Date: Mon, 29 Jun 2020 11:38:57 -0400 Message-Id: <20200629154007.2495120-122-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629154007.2495120-1-sashal@kernel.org> References: <20200629154007.2495120-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.9.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.9.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:39+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal [ Upstream commit 0f44b3275b3798ccb97a2f51ac85871c30d6fbbc ] nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no Fixes tag applying here as the use of nand_release() in this driver predates by far the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible. However, pointing this commit as the culprit for backporting purposes makes sense. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-49-miquel.raynal@bootlin.com Signed-off-by: Sasha Levin --- drivers/mtd/nand/sharpsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c index 70e28bfeb840f..661b4928e0fcf 100644 --- a/drivers/mtd/nand/sharpsl.c +++ b/drivers/mtd/nand/sharpsl.c @@ -192,7 +192,7 @@ static int sharpsl_nand_probe(struct platform_device *pdev) return 0; err_add: - nand_release(this); + nand_cleanup(this); err_scan: iounmap(sharpsl->io); -- 2.25.1