Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3038309ybt; Mon, 29 Jun 2020 13:36:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRe3BjZy7F7iSyxhNaXB6kaglY2yTlYM7G25ikIg2BjBscB27U+Q1aFyFQsL4wJUKiwCx1 X-Received: by 2002:a50:9a63:: with SMTP id o90mr19151837edb.95.1593462984655; Mon, 29 Jun 2020 13:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593462984; cv=none; d=google.com; s=arc-20160816; b=CtpPwox05QEMSOrRsRZjVSF8F9Tp4gvIqW9w+92C4BnvD6hDmSWpC6lRyVL4akEk3K Tf/qeMrZh7U4xsSKwCBxtUDcHAxfphWVI3rGeBC1vymnTm9vzsRLVqUL5RWUNZhGvzjI j0vzgA6/NeC88Bi7ianm5TWG6ytmvJfD9zbq0itgplQOA/vB2Ei8Y3PelGk0bAQqCtBw IAjxpBieWYw279H0lstdl7T1D39eWA3KwBr4qC4H4GUwL59dtb6RWm1ajXJ6ELiBOeSs QXN2LU6s/if337UWCdHZxpHt709WCHtabEM0OxID59zIta4VXG0OMlN5VdoTc1mTRIzW xnGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1VVUJQAs185+LqJfSzd5ozbQgDlvTWuK2/IWaLB071U=; b=DSn4FGqw5CD8gtvOtUGlGQ+4CgpKYD7FuBd7dWzXC8oEKphQ2RWVxueZTMSHVi3iBr Xr5HhRTRM3lDjFslKKMBxDKVPsS713bSqp2m5oRAjQGey+/zbj98xvP6vutzwCoGsSEF /nqEpVVmuVocK8NwVSEdB8uWM00tiD3Ln4V/ENjXd7/7yAkLZL0hfnWgywY7F3XC7VZX Hn9HjwdoIJ91kv9u+Sjc3FtQJtLPSkH/DKQzirNfAcp638F2Iyb0P4qO6nic54d95yCR eG9cUK/Xk051rtgQrPuaOaSWqdSDdK1q8vScnbUcd6j9fZkawTOunn3fYMHdCCUKuaul h10w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WpOE0tpv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch9si374609edb.155.2020.06.29.13.36.01; Mon, 29 Jun 2020 13:36:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WpOE0tpv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732668AbgF2Ucj (ORCPT + 99 others); Mon, 29 Jun 2020 16:32:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:37028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732404AbgF2TZS (ORCPT ); Mon, 29 Jun 2020 15:25:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1086B252F0; Mon, 29 Jun 2020 15:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593445121; bh=l1LMlFhw0Ak3TciF5P/+7RtZVVAiDO+TqlwcpKCm41k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WpOE0tpvmBBM2We7hIKW5d4Ra2fuj7UtFIJaY3xj6wh07InuHSM9bUDlFo6gMek4W BJkcJFGzyCmRHloTWDZQa16rnM5l8HwrO/W1DHsamJ9O5hWt9tkmpU46xsltVjbqiL etrkwNfeTiOQYtCkGjNbaq2zme4PzFlc1QmtARGA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tang Bin , Zhang Shengju , Greg Kroah-Hartman Subject: [PATCH 4.14 28/78] usb: host: ehci-exynos: Fix error check in exynos_ehci_probe() Date: Mon, 29 Jun 2020 11:37:16 -0400 Message-Id: <20200629153806.2494953-29-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629153806.2494953-1-sashal@kernel.org> References: <20200629153806.2494953-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.186-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.14.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.14.186-rc1 X-KernelTest-Deadline: 2020-07-01T15:38+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin commit 44ed240d62736ad29943ec01e41e194b96f7c5e9 upstream. If the function platform_get_irq() failed, the negative value returned will not be detected here. So fix error handling in exynos_ehci_probe(). And when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Fixes: 1bcc5aa87f04 ("USB: Add initial S5P EHCI driver") Cc: stable Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Link: https://lore.kernel.org/r/20200602114708.28620-1-tangbin@cmss.chinamobile.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/ehci-exynos.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 26b641100639a..be72a625dc217 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -199,9 +199,8 @@ static int exynos_ehci_probe(struct platform_device *pdev) hcd->rsrc_len = resource_size(res); irq = platform_get_irq(pdev, 0); - if (!irq) { - dev_err(&pdev->dev, "Failed to get IRQ\n"); - err = -ENODEV; + if (irq < 0) { + err = irq; goto fail_io; } -- 2.25.1