Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3049686ybt; Mon, 29 Jun 2020 13:57:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzI/7rUXnnJIiyzywVMnF17ngANl63V0HuQDsbAMcIhqGF+A7gt9r14LUnGHTn1glbhB/Br X-Received: by 2002:a17:906:8316:: with SMTP id j22mr15226651ejx.97.1593464248575; Mon, 29 Jun 2020 13:57:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593464248; cv=none; d=google.com; s=arc-20160816; b=N7tmYS7CW2wNTlPYst0QkEVEpuLmb3rzEitBxc1zPxunQhQrh+1Am4Pf9iPqfCR0zl xBug3Ll733N1LTBM6i63hOhSMCDMa5BF4rQSS8bcbX7dtzXcSsoIIf1Cw5RWGuzNGf+w SGExd+hbpTGwMZHlYJLI+ligyQNM6HfwIaFe1r+/4v2Qm2Ez4YhXnoppUVzfdMmdfc+S 9EuhoV5iHw6dZZNK64HdHkUca9LAD1EEj4tVVwo1uLU93c1caMcQdByMsQcp2Gx8YBt/ WQLAqRszqeqZpD8f1d7KBcBlwbGIg9PPZ1/2T8zHYbdfNSeqT/eVk+iKgemLrFMROYBK bmSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=sbI8TKEwp+tY2xjDFGkRM933FZk+cmQeBdzX+Alr3wc=; b=iA7OJRTeyuehHpxGJniBhyaCcUn8pCrPlC4xgF2KHn1CVEPcbS6exv4joBFW3XmbwI 8/Mi6FbCs86bZT64KyaPjpi4L++OYGxvDsK0BLENpt0BYp6TuzxFW+iIb3F+iOTfTroo J1g0t9iXkG/nGAVES1dU29YEiM8fIQEjMNTiJRuogipvSrbvDM8/WK4cncdjxFWJAXYj cpXqPI7dduUZKXfDnLU1eYO9AeTiBVB45wvYuC/XLTMlWb6Wrm92bguSqRPrJ+7KYTdj admofoM7Z/vh2rLUwR+lNIA2pVFWhKgmAx/0vLFdJ4Wq3zJFcURMeZ0krsP45+ZpKNsL WnPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do5si545658ejc.105.2020.06.29.13.57.05; Mon, 29 Jun 2020 13:57:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732056AbgF2UzG (ORCPT + 99 others); Mon, 29 Jun 2020 16:55:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389797AbgF2Uy7 (ORCPT ); Mon, 29 Jun 2020 16:54:59 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87CA3C061755; Mon, 29 Jun 2020 13:54:59 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jq0nj-002KpE-MJ; Mon, 29 Jun 2020 20:54:51 +0000 Date: Mon, 29 Jun 2020 21:54:51 +0100 From: Al Viro To: Ding Xiang Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] loop: fix passing zero to 'PTR_ERR' warning Message-ID: <20200629205451.GC2786714@ZenIV.linux.org.uk> References: <1592988522-4350-1-git-send-email-dingxiang@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1592988522-4350-1-git-send-email-dingxiang@cmss.chinamobile.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2020 at 04:48:42PM +0800, Ding Xiang wrote: > Fix a static code checker warning: > drivers/block/loop.c:798 loop_attr_backing_file_show() > warn: passing zero to 'PTR_ERR' Better fix the root cause of that the problem - bullshit checker, that is...