Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3057085ybt; Mon, 29 Jun 2020 14:08:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxISEJ7f4CrZhEgXytU3rFlUy0R8hqUfwIsLc8E7/LpgX8vP5ZbNLGBQ5o6RBhLRcEEVJu2 X-Received: by 2002:a17:906:8688:: with SMTP id g8mr15273093ejx.505.1593464913052; Mon, 29 Jun 2020 14:08:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593464913; cv=none; d=google.com; s=arc-20160816; b=M1EqaoujqgiISE+h6/zhBEAUmNkAXHydsp2wfGJL9k6FDSM1y9qTvyPnne+R9mPzJN 7s1Etcfl5c5QFf6jXeFB0YjShjoI07nzKzIkWt1THCo0J2oI2RpkSUdkka463cRIHXZ1 l6/ikjOxekpR9dZ9V/iV5spApHI/TsOU+wuSQCWma4yY9wj1p9bB+5Vq3pM0IFg78FAq hsPtoGPjQUlYUWJ+J8gK1fDTF6F8A5qE8GrMUA8I8h8wQLh7y5iu84itFBzdorfcj37K qr5FFW2tGj9LL5xodbUwjf6KSfgcnvwYdaDO3rbF1aBFzhSibyKPChOTBl/BJXPeRvrg FuKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Zbwjbez72BmJ6hUMzryvJmkRLpZxLHayBSZL7Cjo4Zk=; b=mF2f6539TEu/4Ai3tljfIxr8TLJwPUb7Mf8RWVbXlprk7D/oNljVMJCyil2p5MDzfc gK20Q7q9NXHVHHToJ5609VXtwuICqSyr6+G0NX35dMDupWKF0tkoGlc2rq00PN7oogqX rOXKp5gXPB0OHOqT+M7ZWIbnk9kDzT39ZAyEdnL2O+OuznqFMCvhk+vXVb/jZ6FtGHjk ScH5f5fVZSndM9ID9mCcbbFw2BsRHzfutlYVi9M2OsoxTUoLwnfwdWFE2HahpWcWhL/K Gfb0EV60SmTkjqJQd9xPwJ/ywMNkmdzBJyYZunHbi/Vxbkk5pmVmiPkMD8XIQFvMYYmM eM8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ivqGkrn8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x22si454539ejv.520.2020.06.29.14.08.09; Mon, 29 Jun 2020 14:08:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ivqGkrn8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731145AbgF2VGY (ORCPT + 99 others); Mon, 29 Jun 2020 17:06:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:53738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730748AbgF2TKS (ORCPT ); Mon, 29 Jun 2020 15:10:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE53E254B6; Mon, 29 Jun 2020 15:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593446011; bh=AgRFdOEPmRGhMwYWEDiAD/ydaphTjPBnO+pOw4nCiM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ivqGkrn8GCp+UeowK/7yCYprxII02l4YWmuzhtTMujhjcBh4VFHadXsdzlObGvG6u xiSXRv+PnqxzdMjjjVZEtflzR56eI57lm4kAm/cYaSBYFJHXjBcLWOUS1glAMVHC6+ fxvOrFHwsW5HwRXu+YqqbLbfcbO11QxyIcIQ4vjQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tyrel Datwyler , "Martin K . Petersen" , Sasha Levin Subject: [PATCH 4.4 018/135] scsi: ibmvscsi: Don't send host info in adapter info MAD after LPM Date: Mon, 29 Jun 2020 11:51:12 -0400 Message-Id: <20200629155309.2495516-19-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629155309.2495516-1-sashal@kernel.org> References: <20200629155309.2495516-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.4.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:53+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tyrel Datwyler [ Upstream commit 4919b33b63c8b69d8dcf2b867431d0e3b6dc6d28 ] The adapter info MAD is used to send the client info and receive the host info as a response. A persistent buffer is used and as such the client info is overwritten after the response. During the course of a normal adapter reset the client info is refreshed in the buffer in preparation for sending the adapter info MAD. However, in the special case of LPM where we reenable the CRQ instead of a full CRQ teardown and reset we fail to refresh the client info in the adapter info buffer. As a result, after Live Partition Migration (LPM) we erroneously report the host's info as our own. [mkp: typos] Link: https://lore.kernel.org/r/20200603203632.18426-1-tyreld@linux.ibm.com Signed-off-by: Tyrel Datwyler Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ibmvscsi/ibmvscsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index e26747a1b35a1..e7075aae15daa 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c @@ -427,6 +427,8 @@ static int ibmvscsi_reenable_crq_queue(struct crq_queue *queue, int rc = 0; struct vio_dev *vdev = to_vio_dev(hostdata->dev); + set_adapter_info(hostdata); + /* Re-enable the CRQ */ do { if (rc) -- 2.25.1