Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3057597ybt; Mon, 29 Jun 2020 14:09:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX/uwWknRphAJoBs9TooYNzvo8GEHIxxTaCsIS5ThkeVnIeJFtNbMPeIkt4zCyDeRYUtQf X-Received: by 2002:a05:6402:c06:: with SMTP id co6mr19986222edb.142.1593464959995; Mon, 29 Jun 2020 14:09:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593464959; cv=none; d=google.com; s=arc-20160816; b=AY+rpzuPFFv5HopU1y/idggKmkNMshDCv5WMVI/m+2m/8NxLiwZ6Xt+mkyd7+hD6DN G3I3Seb814ycz8FIVUrGuzaFHQJ0zqzutBPHGV0OiD+8EHvic5HtAKKmnfZ3Ch1iAVGD hctngQeCrWjxKH2FBYWgEP1/YciTZmZ6rd8sBnvrm4NujPZT/6tEreWlkwh/6k9zg36L wOELEV4IHCMZtDTNUo5SqFrUIeSKhlZKcf0VvcjHi/MYyqqUjKvw8HqK+VZY3LdEgBX+ +Dp4V3Fp8y1qQUWGK11Z1PtTL/OaZm4N0FElGwzU75xhwm5LKhzv1mRKY5vbfyJxjqro tyMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YgLSw/PWqiA680dOdj29VE1ZYgmrK0WHgRjm/JaWVvY=; b=RQspFodg8G3T+vRquPrJ2PvTgSqxG1avBvHpHlA6kIyGLNliQVhSbdOxzQbl/FplHu uL0O04jRhjZ5Dt+JwnPGzAoHNspnIqzgZBQlW5VIvUPifpp/ty6ZRv+SWhCd39cxx4Lp 2i2BFVmQVFoEeEsr5I0hCKYfKpz1S8TQu9fKbgNU8FgK1ZB8tPk4OFuQ7VocV7WSgb+E fNBdD9qy/ZbYjnhpFxsjKoMh+FrgOKVIRwW34Y3FeXmQCyqlKG/s3lK0egzkHYbHw5oj +lS5C7Ze9wa9cdWkhqpcqSVyA0Y+vl7G/TW//pK7ruQjhITgQJO7TrCEGA1gGViYhDUF 8qew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eXbPthKr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o3si493590ejm.346.2020.06.29.14.08.57; Mon, 29 Jun 2020 14:09:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eXbPthKr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390376AbgF2VHe (ORCPT + 99 others); Mon, 29 Jun 2020 17:07:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730828AbgF2TKR (ORCPT ); Mon, 29 Jun 2020 15:10:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12156254C8; Mon, 29 Jun 2020 15:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593446021; bh=HNyBE1hTrNXbSBGAqMnk8Ynsekr44GsKu7muWPFXWPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eXbPthKr1UZRXuLsB8TOp8DJPpkKewLzAC7TPZUqXaqQz1WUYPOn8V5ZVIZsTDLnq RiG+MYD2c5Hfx9EsZi/lz8vyhLOr4vj1o7LSYoi4PGTdOJIrprvXWdg9QkoFTQiYwF 0xAiqZlN1o1wG8bIiL3jHuL+emca+/ZvR3htLcxQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Suganath Prabu S , Dan Carpenter , "Martin K . Petersen" , Sasha Levin Subject: [PATCH 4.4 028/135] scsi: mpt3sas: Fix double free warnings Date: Mon, 29 Jun 2020 11:51:22 -0400 Message-Id: <20200629155309.2495516-29-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629155309.2495516-1-sashal@kernel.org> References: <20200629155309.2495516-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.4.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:53+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suganath Prabu S [ Upstream commit cbbfdb2a2416c9f0cde913cf09670097ac281282 ] Fix following warning from Smatch static analyser: drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->hpr_lookup' double freed drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->internal_lookup' double freed Link: https://lore.kernel.org/r/20200508110738.30732-1-suganath-prabu.subramani@broadcom.com Reported-by: Dan Carpenter Signed-off-by: Suganath Prabu S Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 7af7a08594785..8d52afd1f71db 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -3136,7 +3136,9 @@ _base_release_memory_pools(struct MPT3SAS_ADAPTER *ioc) ioc->scsi_lookup = NULL; } kfree(ioc->hpr_lookup); + ioc->hpr_lookup = NULL; kfree(ioc->internal_lookup); + ioc->internal_lookup = NULL; if (ioc->chain_lookup) { for (i = 0; i < ioc->chain_depth; i++) { if (ioc->chain_lookup[i].chain_buffer) -- 2.25.1