Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3058486ybt; Mon, 29 Jun 2020 14:10:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRTDT5/oHnedHU8N7sp2cllCEhg9PXsKdCFQIJ7ur0K4vgWfGsoUy4YR8axPi6BXrmrAxr X-Received: by 2002:a17:906:144b:: with SMTP id q11mr4469189ejc.511.1593465047647; Mon, 29 Jun 2020 14:10:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593465047; cv=none; d=google.com; s=arc-20160816; b=Fc2Bf9EvO2PgCgxM8h1+8TEuQUIRdWTirjkXE8U2dt24fMMXgy9VNhCApvX3B8nm7R d15p5XUI5imBf5O7k0P1VUdpXTA2Y1qcDcqh6EOVjQ5blZ36rwVUz7jU2OEYI1oLN7Fe JxzdFAVzX8b+OTO8Pyz0tfkFfIbkh21mxXsNGhijdwLhdcBGI4IJX9hgsy8Nx5Gu2EH5 D95oKMdUvUidwRwdoyK1+E2GwrC4OSz5Eob9mecyjTS5e2Irkv2PeAlXX214u8JIhxYv NRowrBtKreNF6W1kXjshhGXLNhRnViovXBAXosdgjOmWqnClxG41YrM9+Yod75+FXPYk 2YwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=o5ZlyKZBFoudiH85k/eVyHe20++XQKFukkoI1E11Nbk=; b=onIfur7TEsErC3n7LvqatC6ZYVEfhbFjP8rA1pzbEx/VAkzovBDMWAQr95NbobLhmk l521tOjYJ0Bj6+FDhtpkUmAowTS3uvBcbBY66B4DcV45fHguOp+/84LkoQNDRUk1mkpE SlcToZvF0Xq5nAP0lAbgiQoZSVbxVtmJQwZ+ErgX79QYSX5cQW0v+pWf/j1pnook+Gjd oH4lXqcbB4ti9PYnAm2uCJ79Ia1rFCrEKeGskZRMjFudHs1JgTe3oVmwkCgLsl4rKu07 FKYJsqCe6p4XMvjdVjk8h60hpVrmVdLgocpQ285uDwnFvC9TBDXpRCDCZf7h8TVUcRsA Y3qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gYubyolt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by12si331059edb.99.2020.06.29.14.10.24; Mon, 29 Jun 2020 14:10:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gYubyolt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390346AbgF2VHJ (ORCPT + 99 others); Mon, 29 Jun 2020 17:07:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:53756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730957AbgF2TKR (ORCPT ); Mon, 29 Jun 2020 15:10:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36503254CA; Mon, 29 Jun 2020 15:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593446024; bh=XGuWL52K+qAbtTA70o3IBFExy55ErqwDzLBqz/ZsfZU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gYubyoltP+z/2jeiqTfZXc7luL1gAvngx30Yt8wZHBjEFjxE5Yi3bXDB85Sp7Agmu AalogZ+EG9gc7aswzHzGU68E0JtAnN8Ps6T4O/Zpbf919Ws6FfLhBV2WDE5cpK8wgY Xkzueyn/VJmkHD1Vri5dkV2jDeGZXstBsxnFhv+0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tero Kristo , Tomi Valkeinen , Tony Lindgren , Stephen Boyd , Sasha Levin Subject: [PATCH 4.4 030/135] clk: ti: composite: fix memory leak Date: Mon, 29 Jun 2020 11:51:24 -0400 Message-Id: <20200629155309.2495516-31-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629155309.2495516-1-sashal@kernel.org> References: <20200629155309.2495516-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.4.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:53+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit c7c1cbbc9217ebb5601b88d138d4a5358548de9d ] The parent_names is never released for a component clock definition, causing some memory leak. Fix by releasing it once it is no longer needed. Reported-by: Tomi Valkeinen Signed-off-by: Tero Kristo Link: https://lkml.kernel.org/r/20200429131341.4697-2-t-kristo@ti.com Acked-by: Tony Lindgren Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/composite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/ti/composite.c b/drivers/clk/ti/composite.c index dbef218fe5ecd..14201c52b44bc 100644 --- a/drivers/clk/ti/composite.c +++ b/drivers/clk/ti/composite.c @@ -228,6 +228,7 @@ static void __init _register_composite(struct clk_hw *hw, if (!cclk->comp_clks[i]) continue; list_del(&cclk->comp_clks[i]->link); + kfree(cclk->comp_clks[i]->parent_names); kfree(cclk->comp_clks[i]); } -- 2.25.1