Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3059136ybt; Mon, 29 Jun 2020 14:11:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQgGMobQ5gc2woOKfMWkT5pXedYx3EHncSgG8P+z05fEG3dB44RxWRzdNgwhP2LW8kzp/1 X-Received: by 2002:aa7:c3d8:: with SMTP id l24mr13152376edr.97.1593465112113; Mon, 29 Jun 2020 14:11:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593465112; cv=none; d=google.com; s=arc-20160816; b=NT+lBqMdMYQOKubHAiklV8dRCZ622y4rKF/46LlYyU5JsMyVNXdt64wBAbMrUQMM41 5uXiz8QmPKG4M0CtbAPo9lx7clHtE67BFvTqKEjKNf93JahSdrKrQ8QmiQonIPaDamhN 5VBRR2dHLaxSP++C3Go8uEtjQUA3JPEL0C9AAAHbPnjAIipHUwTeUPoeniOikcZcyg46 wc6/mGCVDY9F7wCZS6v4Szo18zkpK8vg/xej6DHRAxaAvw8Qmk1IPOFcaIqmR4fS7cQw 9MT9ilzcdNbddHyUl7sRefE7xetG6Duxaoi1tWC/jHoCfukXZnhg63WM3CXLcr4YG+pB FRLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gb5ml2G1nMS0Gp19sF4esxN7/UCu3kfffBY15tbA95g=; b=tzxgBKg/Pw+jGAsqYkT4lkSD92cJCXvto6L/zqUWX7e6qwcKx8Wngr32iO5BvmCLjk +xyYXgA0tw3zBRMqOA/z70qB6foFeRRkZGXsA9AvtzOgU6BOLMTWdYbGBHKJhlcLBMFv e356jXrNv7/+czuZs02W9sITPWrjpK6C4gxD3+IPzCTC5A/r2iTVq6KaqPqal3+ezRUq eAf1/9T/oDv6utcaHxpTx4gK3u5FGrh8i+hQzvOYkE5XKW5iWPDDlb5Zl+val26HRZ1v +BpU4AgjUKLxnaWc7MzNpnzAGuNwxxVS6uP3kiD0Y4lV/KcaujMjNOzV1LAXp/WTDXdd B27A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iE6jXckE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w9si353133edr.171.2020.06.29.14.11.28; Mon, 29 Jun 2020 14:11:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iE6jXckE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390310AbgF2VJz (ORCPT + 99 others); Mon, 29 Jun 2020 17:09:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:45438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730317AbgF2TAS (ORCPT ); Mon, 29 Jun 2020 15:00:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C98B25547; Mon, 29 Jun 2020 15:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593446112; bh=X2/nW0/ATkt/O4jFYk04z1KIG21LoVAKHQ/fYuqldp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iE6jXckER5Rdh32ddGVH2lLfZBUjxB61GuS53rTct7CKvLXVFtZ++GmvWy9OmBaqK 744R8XRX0aazbOkKv3g13ZV29FIHyPyntKrWHPCvEuJ8sJN4bQH2TSBBeCBJv/GVPE a0W05hTIrU/wj5uKmQcSxFG9jTz6oXvDwq1SKsC0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Joakim Tjernlund , Oliver Neukum , Greg Kroah-Hartman Subject: [PATCH 4.4 103/135] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip Date: Mon, 29 Jun 2020 11:52:37 -0400 Message-Id: <20200629155309.2495516-104-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629155309.2495516-1-sashal@kernel.org> References: <20200629155309.2495516-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.4.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:53+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joakim Tjernlund commit 03894573f2913181ee5aae0089f333b2131f2d4b upstream. USB_DEVICE(0x0424, 0x274e) can send data before cdc_acm is ready, causing garbage chars on the TTY causing stray input to the shell and/or login prompt. Signed-off-by: Joakim Tjernlund Cc: stable@vger.kernel.org Acked-by: Oliver Neukum Link: https://lore.kernel.org/r/20200605105418.22263-1-joakim.tjernlund@infinera.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/cdc-acm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 04fd6c8e3090d..515839034dfbc 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1684,6 +1684,8 @@ static int acm_reset_resume(struct usb_interface *intf) static const struct usb_device_id acm_ids[] = { /* quirky and broken devices */ + { USB_DEVICE(0x0424, 0x274e), /* Microchip Technology, Inc. (formerly SMSC) */ + .driver_info = DISABLE_ECHO, }, /* DISABLE ECHO in termios flag */ { USB_DEVICE(0x076d, 0x0006), /* Denso Cradle CU-321 */ .driver_info = NO_UNION_NORMAL, },/* has no union descriptor */ { USB_DEVICE(0x17ef, 0x7000), /* Lenovo USB modem */ -- 2.25.1