Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3060731ybt; Mon, 29 Jun 2020 14:14:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdjJkZMJ0ICqJkdoW5ryCswnj41InvNho2T6tNW8lmOVJ84QC5BYeCv7gF//wqwNJmSWXe X-Received: by 2002:a17:906:9147:: with SMTP id y7mr14469988ejw.399.1593465261177; Mon, 29 Jun 2020 14:14:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593465261; cv=none; d=google.com; s=arc-20160816; b=Cc9z+4nlDCzDT+p7jMUeNrr1P4Bveg5GLaYM9iZ49TcKw87U9MXaqJAbvFSkUBNc/6 ro/cobCcOsDpe//T3nlwOP5yTPLrOayIW5kQ8KkpKAu09VO/s3CoS7TNs+n78I5ZBuj8 tGfLsfzF7jhlTt91zwUaCj+tG6DECuc6i6sgP+H7KvGzdRYHpdx0nCvAZ0LA9JJINZmp l/SyCMPLyCCT70kh2krOXeNuRdraf3M/I7pDPMfG1VYPj+s6x+O9/8if/7/VTqzcUBQJ Q0qJv9chaEa5q2kOOjjmpfqnjk7ndkm40gdooHJGP2/GVwCGXNpgtaIjXjc5WquVhXHn XoaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=nLPL88OfKWPjoDgMrUq7HX0bJ21PFQyFVAStT19x/30=; b=Bmq9IPlkgsDV0a0QJpsDao8x7jnX8ZLxyHWLE3ApeSGmaMgYGVHofWlDJIgpQiiEdu Pf8aySn+jtEiJooMVIoex5PtZgtLP/ZBXUbxxMc3C7DNlq6PfcI+Q36rp+RfcOo2SxWc okJqMxBKoiQkMaY5DoXirGgpDBeZxlZOnvdMmnEvv6CMQFeAN664jNyqf45dQSBUuZr1 X0Hn5M9x5lu3eUYHgnqkpJ+ZhOZgxmVyapO9KNzNGWzwCtxcu8GM8m6OWFZXGb0VQoVk e5gK+xqlUTAxYngZFGBhAs5Ba3S2YB8rqDmRnkcyK+FGxKrzODLj6TGSU3SqET80F+Sx 8RZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@beagleboard-org.20150623.gappssmtp.com header.s=20150623 header.b=PSx0WywE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk22si435053edb.289.2020.06.29.14.13.58; Mon, 29 Jun 2020 14:14:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@beagleboard-org.20150623.gappssmtp.com header.s=20150623 header.b=PSx0WywE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730150AbgF2VMd (ORCPT + 99 others); Mon, 29 Jun 2020 17:12:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730152AbgF2S5o (ORCPT ); Mon, 29 Jun 2020 14:57:44 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D97C00F802 for ; Mon, 29 Jun 2020 05:29:03 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id p20so16333159ejd.13 for ; Mon, 29 Jun 2020 05:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nLPL88OfKWPjoDgMrUq7HX0bJ21PFQyFVAStT19x/30=; b=PSx0WywEstp6kzCgrb2T780nS7vnNFzJS+U+DK53C0PhGN6LZvYDc2EFvOEAdEmhEj RUqqwUYHPI+moJOm1Lu+qDnTY8k7w4i1ZmDLAcEGCt5/VfkthQIciG4scNhgkF7qBZsF vapojTxZMy6hzLbJ19FtwmOG4LeFbtDfvu2hGXI5r15prpIVDn5Q6Ex36/ORxBC8HOMu p8sNi03zdwEm4JKaNFhsJFwkK43/7a69OrK8KLs3I2Jj3FUWqdHQLOJ+ViEJxwPsy3tk RJ+tPHTitdFJ/MPwm7Oci+jsb+VVt/S6RIkCjMGIh8K6vN3UA3j4206+/RBfGp3XCb1e Wcrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nLPL88OfKWPjoDgMrUq7HX0bJ21PFQyFVAStT19x/30=; b=na+EoObF9ajzqcgmxD+WyurO+6Mx7BQLDM0DYtGJEV+ukuHqAjHM2RVWXNJHPN5xco 6F41g6EcMlkF143NzbbxP2iuX/TQJjVlalqUPGFLp9wDrEMPBZ90gilt8iK9jAS089Bb YFY1mF+KO57n5/k3g2RuZseh1V0fXuDuygUV6/AvCUyoBY5f2E2ROFwn71HZtYqrswPm e/n+Nz43xZQ+HIutNFKbzQBVG/yaWdm1TuAj1iJcpWkiHrNfyCFbvFghBR2OE8iBoBt5 L/bV4vto16rmdj7d43Ss/jam1Udy11AwLGwQbfiTgDjbVZhDcVTyIcjxfJ8RlEJBDuPL sBSg== X-Gm-Message-State: AOAM532EH19XuItOfE26cQXLpdEOT5R777vgsw4voUYYKydgxjlw6piQ nDbwtHaN0R1Tom4ZfVdQwNJnsw== X-Received: by 2002:a17:906:fa15:: with SMTP id lo21mr14416147ejb.156.1593433742019; Mon, 29 Jun 2020 05:29:02 -0700 (PDT) Received: from x1 (i59F66838.versanet.de. [89.246.104.56]) by smtp.gmail.com with ESMTPSA id a1sm18278094ejk.125.2020.06.29.05.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 05:29:01 -0700 (PDT) Date: Mon, 29 Jun 2020 14:28:58 +0200 From: Drew Fustini To: Tony Lindgren , Rob Herring , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Haojian Zhuang , devicetree@vger.kernel.org, bcousson@baylibre.com, Jason Kridner , Robert Nelson Subject: Re: [PATCH v3 0/3] pinctrl: single: support #pinctrl-cells = 2 Message-ID: <20200629122858.GA506802@x1> References: <20200622172951.524306-1-drew@beagleboard.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622172951.524306-1-drew@beagleboard.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2020 at 07:29:48PM +0200, Drew Fustini wrote: > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then > pcs_parse_one_pinctrl_entry() does an OR operation on to get the > value to store in the register. > > To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in > omap.h is modified to keep pin conf and pin mux values separate. > > change log: > - v3: change order of patches to make sure the pinctrl-single.c patch > does not break anything without the dts patches > > - v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a > compile error in dtc. I had added it per suggestion from checkpatch > about having parentheses around complex values. > > Drew Fustini (3): > pinctrl: single: parse #pinctrl-cells = 2 > ARM: dts: change AM33XX_PADCONF macro separate conf and mux > ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 > > arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- > drivers/pinctrl/pinctrl-single.c | 11 +++++++++-- > include/dt-bindings/pinctrl/omap.h | 2 +- > 3 files changed, 11 insertions(+), 4 deletions(-) > > -- > 2.25.1 > Hi Tony - do you think this series is useful as-is? Or do you want to see some usage of the seperate conf and mux values first? thanks, drew