Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200629161333.2110327-1-pmalani@chromium.org>
 <20200629161333.2110327-2-pmalani@chromium.org> <CABXOdTe_t94GL6soaZbXp5TVxnG72zHRqh_qTa+zpmzTCw50ng@mail.gmail.com>
In-Reply-To: <CABXOdTe_t94GL6soaZbXp5TVxnG72zHRqh_qTa+zpmzTCw50ng@mail.gmail.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Mon, 29 Jun 2020 09:29:30 -0700
Message-ID: <CACeCKafrDOyziU5-FmOWQ8cPojxTgwo49osZFgmeO4O33QAGbg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Add PM support
To:     Guenter Roeck <groeck@google.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Guenter,

Thanks for reviewing the patch.

On Mon, Jun 29, 2020 at 9:25 AM Guenter Roeck <groeck@google.com> wrote:
>
> On Mon, Jun 29, 2020 at 9:13 AM Prashant Malani <pmalani@chromium.org> wrote:
> >
> > Define basic suspend resume functions for cros-ec-typec. On suspend, we
> > simply ensure that any pending port update work is completed, and on
> > resume, we re-poll the port state to account for any
> > changes/disconnections that might have occurred during suspend.
> >
> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
> > ---
> >
> > Changes in v2:
> > - Remove #ifdef-ery, add __maybe_unused tag to functions.
> >
> >  drivers/platform/chrome/cros_ec_typec.c | 26 +++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> > index 630170fb2cbe..b2e7e928e788 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -725,11 +725,37 @@ static int cros_typec_probe(struct platform_device *pdev)
> >         return ret;
> >  }
> >
> > +static int __maybe_unused cros_typec_suspend(struct device *dev)
> > +{
> > +       struct cros_typec_data *typec = dev_get_drvdata(dev);
> > +
> > +       cancel_work_sync(&typec->port_work);
> > +
> > +       return 0;
> > +}
> > +
> > +static int __maybe_unused cros_typec_resume(struct device *dev)
> > +{
> > +       struct cros_typec_data *typec = dev_get_drvdata(dev);
> > +
> > +       /* Refresh port state. */
> > +       schedule_work(&typec->port_work);
> > +
> > +       return 0;
> > +}
> > +
> > +static const struct dev_pm_ops cros_typec_pm_ops = {
> > +       SET_SYSTEM_SLEEP_PM_OPS(cros_typec_suspend, cros_typec_resume)
> > +};
> > +
> > +#define DEV_PM_OPS     (&cros_typec_pm_ops)
>
> I don't think this define adds any value.

Right. Sorry, got sloppy here. Will push another patchset. Thanks for
catching this.

Best regards,

>
> > +
> >  static struct platform_driver cros_typec_driver = {
> >         .driver = {
> >                 .name = DRV_NAME,
> >                 .acpi_match_table = ACPI_PTR(cros_typec_acpi_id),
> >                 .of_match_table = of_match_ptr(cros_typec_of_match),
> > +               .pm = DEV_PM_OPS,
> >         },
> >         .probe = cros_typec_probe,
> >  };
> > --
> > 2.27.0.212.ge8ba1cc988-goog
> >