Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3062232ybt; Mon, 29 Jun 2020 14:16:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwE83KaFpmQegZoY86kyzgeZwc2GXpCMPTw1BI93TxiqbGOu2HtIiuZCJ2wyBEaRVPS8Qdz X-Received: by 2002:a50:c355:: with SMTP id q21mr17231873edb.121.1593465397290; Mon, 29 Jun 2020 14:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593465397; cv=none; d=google.com; s=arc-20160816; b=QaBQufrnKv9tQbgoMDCALBCQHPHBzxPQz09U9aMv3OfpHYFVVYxdTNZqm0TaI1W+3f DIZMwut53c5HeHDJaiybOedzGy8xs/QZAHthH8bzUeNPyTE1Fi3SGoUg3OY4xcpiQtDg H8joaipGnO5pr12Ji7A2/rng4EmfDtEO331R/sKSTaU94R+IUpdkPOADunwAbeGUOg7Q g2dfog7wcEQiSK1IQfvXb2nXQAe3yDmLp8lmf5+bLrecoDhMi7rb/l05h2LQXl9dcbiS h+L5FDz5h8xr1hg8Tl23mP0DD9M5edMRG6E7tZ7lM4E/TqeIPx3J4PI+Ejv8NePSkSne wP2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bw1MEz5Kxfy+BvJfT3ukwcR70i/vse/X9vRZKj4XRog=; b=JhXU6C7RAggnbiOXG6NuYe+dDHbmjahcXsTh3k4KJ6PZXkIsuccezV7I1eEO/BAiDt /7WDOESNiiQHSxQ2LsF4shPrXUqCObH7lVR+0LSxPqrBHSYkpATb5YRH9xG4Uca4UJap 7jzsTk6FmoILGoslZx3bEldy0hZM5hSTP2RaIaQ99FWlEzLrsqeJXQjUJqBGhZdUt/62 SlQMN8UwelfgXEE1XUM7048FoaRNrXaA/fneYz2o9EBIf9RfRUjWkbP8r1q4bjG2+57L XYZPIP0lLAs6CFeKLvuxWX+nY2DWRYf96P+7fl7ddHHFB2ayqsjPmQjHTzPpOjV8bXtF QD8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BLprKUfT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o15si339472eja.702.2020.06.29.14.16.14; Mon, 29 Jun 2020 14:16:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BLprKUfT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728049AbgF2S4r (ORCPT + 99 others); Mon, 29 Jun 2020 14:56:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:42442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729344AbgF2SzR (ORCPT ); Mon, 29 Jun 2020 14:55:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4439125560; Mon, 29 Jun 2020 15:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593446123; bh=tzLUPNuFjhni840cOZi9CFA58r7CpGWMWGFnbgO4BHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BLprKUfTxO7jGtTMcHMFbMJiGNU4gKoLH+klYaCER4DQ38s/Qr0aOL7gMm2vtDvRq yMLpF/+GYshiG0uh7efkCGpJg7uMNRDMsfdE4kVKbnQa2S41/dEWSpppYw7sqsCA3U TRACEzS4iPV9e0xrwDw1XU5w+JWZTEIv7Ent+Zyk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Felipe Balbi , Sasha Levin Subject: [PATCH 4.4 114/135] usb: gadget: udc: Potential Oops in error handling code Date: Mon, 29 Jun 2020 11:52:48 -0400 Message-Id: <20200629155309.2495516-115-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629155309.2495516-1-sashal@kernel.org> References: <20200629155309.2495516-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.229-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.4.229-rc1 X-KernelTest-Deadline: 2020-07-01T15:53+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit e55f3c37cb8d31c7e301f46396b2ac6a19eb3a7c ] If this is in "transceiver" mode the the ->qwork isn't required and is a NULL pointer. This can lead to a NULL dereference when we call destroy_workqueue(udc->qwork). Fixes: 3517c31a8ece ("usb: gadget: mv_udc: use devm_xxx for probe") Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/mv_udc_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index 81b6229c78054..4f480059f851c 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -2322,7 +2322,8 @@ static int mv_udc_probe(struct platform_device *pdev) return 0; err_create_workqueue: - destroy_workqueue(udc->qwork); + if (udc->qwork) + destroy_workqueue(udc->qwork); err_destroy_dma: dma_pool_destroy(udc->dtd_pool); err_free_dma: -- 2.25.1