Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: TGSsAO0QifWNbSlhVttjdXOmDKeFeN8Y0yRg+FbTMrfEJJz6xO0nEvQNk1Cl9aJcpAPPqahxxH
 9OKqu3U9u04T8FFl+HpCzDywCoBCueaQXlqd48LA7tRTlAOKojlt8zJBLjezezURko2VUCX3+p
 EzPNidm1vrhIzH9V+b1CAdIOzA5ME91hlitbCFb2SxhGVWnBvnL5z0K8hrzJogoLB8/WFEyWYU
 nffpmHmgL/xqAU+t+o+YRJtHFTLeu112YGk0SFStjhtstSBFLfyRxL/LckxIPJ4oyxNgZzAgNc
 Na4=
From:   Matias Bjorling <Matias.Bjorling@wdc.com>
To:     Niklas Cassel <Niklas.Cassel@wdc.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>
CC:     "axboe@kernel.dk" <axboe@kernel.dk>,
        "kbusch@kernel.org" <kbusch@kernel.org>, "hch@lst.de" <hch@lst.de>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        Hans Holmberg <Hans.Holmberg@wdc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: RE: [PATCH 1/2] block: add zone_desc_ext_bytes to sysfs
Thread-Topic: [PATCH 1/2] block: add zone_desc_ext_bytes to sysfs
Thread-Index: AQHWTaAe7EphdXOt6kSWMdnkQNI/YajvTTIAgAAAmzA=
Date:   Mon, 29 Jun 2020 09:07:24 +0000
Message-ID: <MN2PR04MB6223CBCEA07D63E53B3AD244F16E0@MN2PR04MB6223.namprd04.prod.outlook.com>
References: <20200628230102.26990-1-matias.bjorling@wdc.com>
 <20200628230102.26990-2-matias.bjorling@wdc.com>
 <CY4PR04MB375197387D94CE4E60E836F4E76E0@CY4PR04MB3751.namprd04.prod.outlook.com>
 <20200629090356.GA521026@localhost.localdomain>
In-Reply-To: <20200629090356.GA521026@localhost.localdomain>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bc8c23c9-018b-4b60-b6bd-08d81c0bd68a
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 09:07:24.1178
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: O3maUdE2f9GKlEBzkUuLZWehuVX8yb6T3MvC24yJRSb0dm4rlv+ghhvhsW7njbmFW0zsCaIyPebUfNGyebbgAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6047
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Niklas Cassel <Niklas.Cassel@wdc.com>
> Sent: Monday, 29 June 2020 11.04
> To: Damien Le Moal <Damien.LeMoal@wdc.com>
> Cc: Matias Bjorling <Matias.Bjorling@wdc.com>; axboe@kernel.dk;
> kbusch@kernel.org; hch@lst.de; sagi@grimberg.me;
> martin.petersen@oracle.com; Hans Holmberg <Hans.Holmberg@wdc.com>;
> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> block@vger.kernel.org; linux-nvme@lists.infradead.org
> Subject: Re: [PATCH 1/2] block: add zone_desc_ext_bytes to sysfs
>=20
> On Mon, Jun 29, 2020 at 12:52:46AM +0000, Damien Le Moal wrote:
> > On 2020/06/29 8:01, Matias Bjorling wrote:
> > > The NVMe Zoned Namespace Command Set adds support for associating
> > > data to a zone through the Zone Descriptor Extension feature.
> > >
> > > The Zone Descriptor Extension size is fixed to a multiple of 64
> > > bytes. A value of zero communicates the feature is not available.
> > > A value larger than zero communites the feature is available, and
> > > the specified Zone Descriptor Extension size in bytes.
> > >
> > > The Zone Descriptor Extension feature is only available in the NVMe
> > > Zoned Namespaces Command Set. Devices that supports ZAC/ZBC
> > > therefore reports this value as zero, where as the NVMe device
> > > driver reports the Zone Descriptor Extension size from the specific
> > > device.
> > >
> > > Signed-off-by: Matias Bj=F8rling <matias.bjorling@wdc.com>
> > > ---
> > >  Documentation/block/queue-sysfs.rst |  6 ++++++
> > >  block/blk-sysfs.c                   | 15 ++++++++++++++-
> > >  drivers/nvme/host/zns.c             |  1 +
> > >  drivers/scsi/sd_zbc.c               |  1 +
> > >  include/linux/blkdev.h              | 22 ++++++++++++++++++++++
> > >  5 files changed, 44 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/block/queue-sysfs.rst
> > > b/Documentation/block/queue-sysfs.rst
> > > index f261a5c84170..c4fa195c87b4 100644
>=20
> (snip)
>=20
> > >  static struct queue_sysfs_entry queue_nomerges_entry =3D {
> > >  	.attr =3D {.name =3D "nomerges", .mode =3D 0644 },
> > >  	.show =3D queue_nomerges_show,
> > > @@ -787,6 +798,7 @@ static struct attribute *queue_attrs[] =3D {
> > >  	&queue_nr_zones_entry.attr,
> > >  	&queue_max_open_zones_entry.attr,
> > >  	&queue_max_active_zones_entry.attr,
> >
> > Which tree is this patch based on ? Not I have seen any patch
> > introducing max active zones.
>=20
> The cover letter forgot to mention this patch series' dependencies.
> I assume that it is based on the following patch series:
> https://lore.kernel.org/linux-block/20200622162530.1287650-1-
> kbusch@kernel.org/
> https://lore.kernel.org/linux-block/20200616102546.491961-1-
> niklas.cassel@wdc.com/
>=20

Very true. Thanks, Niklas.

I'll rebase this work when the above patchsets have been picked up.

>=20
> Kind regards,
> Niklas