Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1593425623-31810-1-git-send-email-Anson.Huang@nxp.com>
 <1593425623-31810-3-git-send-email-Anson.Huang@nxp.com> <CAK8P3a2wsaS9i9BrV6o845Qx4TJrZM=+13C1haqBLg17HKVgXw@mail.gmail.com>
 <DB3PR0402MB3916E7A184549BF302C7401FF56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
 <CAK8P3a1qSdiKfcgXLAQ8JTWeg4_i+8+qh-7hH5rYiEjp-dJMkA@mail.gmail.com> <DB3PR0402MB3916A6B7F90D3A11AF093499F56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
In-Reply-To: <DB3PR0402MB3916A6B7F90D3A11AF093499F56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 29 Jun 2020 14:02:22 +0200
Message-ID: <CAK8P3a26Z74V__7sCv6Q=ByFJs1f_8wJ9OtgxHgxndeoUCiFRw@mail.gmail.com>
Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D
To:     Anson Huang <anson.huang@nxp.com>
Cc:     Russell King - ARM Linux <linux@armlinux.org.uk>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Stefan Agner <stefan.agner@toradex.com>,
        "oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Leo Li <leoyang.li@nxp.com>, Vinod Koul <vkoul@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Olof Johansson <olof@lixom.net>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 29, 2020 at 1:54 PM Anson Huang <anson.huang@nxp.com> wrote:
> > Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D
> >
> > On Mon, Jun 29, 2020 at 1:36 PM Anson Huang <anson.huang@nxp.com>
> > wrote:
> > > > Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D
> > > > On Mon, Jun 29, 2020 at 12:25 PM Anson Huang
> > <Anson.Huang@nxp.com> wrote:

> > I don't understand. Why can't this driver be a loadable module on i.MX7?
> > Please clarify in the changelog what the bug is on i.MX7.
> >
> > > ARMv7 SoCs is NOT in the plan, that is why I add this patch to make it
> > > same as previously when this reset driver is =y by default. Without
> > > this patch, this reset driver will NOT be enabled by default for i.MX ARMv7
> > SoCs, function will be broken.
> >
> > But it's the same driver, make it work the same way on all chips!
> >
> > I think artificially limiting a new driver feature to one chip just because nobody
> > asked for it on another chip is not helpful.
> >
>
> Understood, what if I don't select it in SOC config which is NOT flexible, but put it in
> imx_v6_v7_defconfig, then user can select either =y or =m according their requirement?

I would recommend using a 'default m if SOC_IMX7' or 'default y if SOC_IMX7', so
any distros and users that have their own defconfigs still get a reasonable
default, but can choose between =m and =y based on their needs.

> And in imx_v6_v7_defconfig make it =y by default.

Having =y in imx_v6_v7_defconfig sounds reasonable if you go with 'default m'.

     Arnd