Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3077766ybt; Mon, 29 Jun 2020 14:44:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfFmIFKWVQheHe9J4wNBzHH5Rkaw6yCdw+D6uVULuIlQetN8XHBpZvnILr5bM4ItUGD7hi X-Received: by 2002:a17:906:40d3:: with SMTP id a19mr16139749ejk.474.1593467093451; Mon, 29 Jun 2020 14:44:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593467093; cv=none; d=google.com; s=arc-20160816; b=HYH/5nlxGT2LLCTgOA2xxzZf+HFGI9WxnCCNIFhx2FQtKAXs3JynaJlgBrQELd8gVG m9SWC/s5VywDglzdYcfnI/7nCwFD3D5sS6IFxR2GKMqrOWZ0UQb/fbcE+Q4NQgd64v25 mZwZr8FGX3WB5Hyt84xctW/X0pS3lSeYOhw80F7zDY2/sKmoofIq71Vx3tVR+PNMB4vP og58D0B3Yvxzlpamyz68v4hqrG2w8m15HaamOosPdlxGnzkYKIzIxT+NhV0tsA121IfI JH5kWwQBnFBMXJ0/l25ZH/qZJ8tEP79wehCRpaJ+uQK0+FeLru3aTMqln2GH5eBhd8LD uVwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=jr1nek3J8zYrEJUnEDGgWevLtl77KOHWAeMwQjMSDdA=; b=FdXe2NFzKqkT6gVwUXb9EyFFCYM95gErlmesM5jPrvp40v5osGGwcQPQhkkymZWDzV rnIsaoI8+q++MbpNpU9nOTZSRZu9MG1v6gM97xhDTzqQi4c876fpNjRYcMfCvQA5vIB+ /eR9pIqrao8vLisP52eEc+dPoowUxaaqHF/1U49BOg5BLESpBKZbKhvQqiS4cCo6cVMX ad/DXki0+Vtr/7aws+UD023z1HTy95ocV5uqBDtNZZtTLwRkYIrGoM/JdPpO/LxE9+9l hzciLuZgyfH6Bij21weWbspSN5oVQ5/0T6PxYKVuFaN2AVopoxPGHIwi8FWmfxDP02KY nsfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="pVTf/0go"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si416115edy.324.2020.06.29.14.44.30; Mon, 29 Jun 2020 14:44:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="pVTf/0go"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbgF2SjU (ORCPT + 99 others); Mon, 29 Jun 2020 14:39:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727947AbgF2Sh7 (ORCPT ); Mon, 29 Jun 2020 14:37:59 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 116DFC02A558 for ; Mon, 29 Jun 2020 06:10:13 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id y18so9016599lfh.11 for ; Mon, 29 Jun 2020 06:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jr1nek3J8zYrEJUnEDGgWevLtl77KOHWAeMwQjMSDdA=; b=pVTf/0go2c42RtZJAsf+7SPFbpXnMlAHaciCTkREVPwihX8fWC2JlSPaEQKBQ/aAJN 5SxsxtgI7FpQUeWLyU1wFDJ2vB0FNaxbrWABYoO26pAL5FpLYvlJE1q3MiQxgjgLGprm xlVWz43m6SWWCSyxCgCvNZtM+U813ehNZ4XALmQxInpS92F4SOVSKTjitku0R8wLOIJq LZmOqql2/CeZZsaggx9uhv7Cew+YebAMKjAeHsa31HD+lfwU9Yi037GVUJm5AVDIsuOO iyHJiCvI3ThpVB7bZlBW4QbASTz/1TVYbD7cR5AGWVM/lTuMOMvDCAt5TRzl5AcxePgW wUmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jr1nek3J8zYrEJUnEDGgWevLtl77KOHWAeMwQjMSDdA=; b=JjINrvpPkXVJrNkDnM4xfcmWa6XWXPsPUdk9544ad9BOSlJTDdquxLx3C95+3hm9ln CoUAL75E1jxReiQUBvsbIZRr4bwZmEyzX/aLBVbJNTNQm31qkf6bLoMDk0UiQEuQOnzP a4zK6z0v562SwL2Bo/zbg67OdBj1OGh6HmwJthXsOFf9c5eZ3cj5QFilSlq5yJUjZH4t zQniGbNNI8A+xU4FfK485rl3xhHPiFVYt7oO8r6kybtrXV/DvchYrcYGpW5TDqhSlc+g QmSqrBPnWfUZAQ7OUqNBn7QugZJF18xs1dIslkTILpKYC97mBBa7FWCiRYCU+5J9oTpq PTpg== X-Gm-Message-State: AOAM533ZIGxgN/ZawqmxZ6rvvVC6A0R+ZN/ztQqHwTNZI6iWBNCZIbXx YOxw5zP5k4MVS/BLC27CGi2CyonbmU/uNVOdGgo= X-Received: by 2002:ac2:5f04:: with SMTP id 4mr9051681lfq.140.1593436211359; Mon, 29 Jun 2020 06:10:11 -0700 (PDT) MIME-Version: 1.0 References: <20200625140105.14999-1-TheSven73@gmail.com> <20200625140105.14999-2-TheSven73@gmail.com> In-Reply-To: <20200625140105.14999-2-TheSven73@gmail.com> From: Fabio Estevam Date: Mon, 29 Jun 2020 10:09:59 -0300 Message-ID: Subject: Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible To: Sven Van Asbroeck Cc: Shawn Guo , Fugang Duan , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sven, On Thu, Jun 25, 2020 at 11:01 AM Sven Van Asbroeck wrote: > > On imx6, the ethernet reference clock (clk_enet_ref) can be generated > by either the imx6, or an external source (e.g. an oscillator or the > PHY). When generated by the imx6, the clock source (from ANATOP) > must be routed to the input of clk_enet_ref via two pads on the SoC, > typically via a dedicated track on the PCB. > > On an imx6 plus however, there is a new setting which enables this > clock to be routed internally on the SoC, from its ANATOP clock > source, straight to clk_enet_ref, without having to go through > the SoC pads. > > Board designs where the clock is generated by the imx6 should not > be affected by routing the clock internally. Therefore on a plus, > we can enable internal routing by default. > > Signed-off-by: Sven Van Asbroeck I have tested this series on an imx6qp sabresd and unfortunately, it breaks Ethernet as I can no longer get an IP address from the DHCP server. Without this series, IP address can normally be retrieved. Therefore I suggest to create a device tree property for this feature and only enable it when such device tree property is present.