Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200627045840.1314019-1-pmalani@chromium.org>
 <20200627045840.1314019-2-pmalani@chromium.org> <cf26168d-bc97-7e35-6f86-a769a36fcc4a@collabora.com>
In-Reply-To: <cf26168d-bc97-7e35-6f86-a769a36fcc4a@collabora.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Mon, 29 Jun 2020 09:08:32 -0700
Message-ID: <CACeCKacaGvAshk0DgMfem23YRppdnSHU=Ewj5qAjUv2x-bqyCA@mail.gmail.com>
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Add PM support
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Enric,

Thanks for reviewing the patch.

On Mon, Jun 29, 2020 at 3:51 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Prashant,
>
> Thank you for the patch.
>
> On 27/6/20 6:58, Prashant Malani wrote:
> > Define basic suspend resume functions for cros-ec-typec. On suspend, we
> > simply ensure that any pending port update work is completed, and on
> > resume, we re-poll the port state to account for any
> > changes/disconnections that might have occurred during suspend.
> >
> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
> > ---
> >  drivers/platform/chrome/cros_ec_typec.c | 34 +++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> > index 630170fb2cbe..68f15a47450c 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -725,11 +725,45 @@ static int cros_typec_probe(struct platform_device *pdev)
> >       return ret;
> >  }
> >
> > +#ifdef CONFIG_PM_SLEEP
> > +
> > +static int cros_typec_suspend(struct device *dev)
>
> I'd prefer if you can mark these function as __maybe_unused (to avoid the
> compiler warning) rather than wrapping it in a preprocessor conditional, it
> makes the code a bit more simple.

Done.

>
> > +{
> > +     struct cros_typec_data *typec = dev_get_drvdata(dev);
> > +
> > +     cancel_work_sync(&typec->port_work);
> > +
> > +     return 0;
> > +}
> > +
> > +static int cros_typec_resume(struct device *dev)
>
> __maybe_unused ?

Done.

>
> > +{
> > +     struct cros_typec_data *typec = dev_get_drvdata(dev);
> > +
> > +     /* Refresh port state. */
> > +     schedule_work(&typec->port_work);
> > +
> > +     return 0;
> > +}
> > +
> > +static const struct dev_pm_ops cros_typec_pm_ops = {
> > +     SET_SYSTEM_SLEEP_PM_OPS(cros_typec_suspend, cros_typec_resume)
> > +};
> > +
> > +#define DEV_PM_OPS   (&cros_typec_pm_ops)
> > +
> > +#else
> > +
> > +#define DEV_PM_OPS   NULL
> > +
> > +#endif /* CONFIG_PM_SLEEP */
>
> and remove the ifdefy
>

Done.

> > +
> >  static struct platform_driver cros_typec_driver = {
> >       .driver = {
> >               .name = DRV_NAME,
> >               .acpi_match_table = ACPI_PTR(cros_typec_acpi_id),
> >               .of_match_table = of_match_ptr(cros_typec_of_match),
> > +             .pm = DEV_PM_OPS,
>
>                 .pm = &cros_typec_pm_ops,
>
> >       },
> >       .probe = cros_typec_probe,
> >  };
> >
>
> Thanks,
>  Enric