Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3084484ybt; Mon, 29 Jun 2020 14:57:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeLS8pFxUkR65pKSL80jR9J3/C146wkcCIXJLQcAwAWJ6DDPss/UlZf3h2UBCby5EtC6kR X-Received: by 2002:a17:906:f298:: with SMTP id gu24mr15521225ejb.302.1593467868299; Mon, 29 Jun 2020 14:57:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593467868; cv=none; d=google.com; s=arc-20160816; b=aU752gcTrUHYbG0ZtEQwHNPNj2EeboQ6oBCJnqYdAyAg0+rsMoDtdyZgf0ZukbhT6O QVfzCezYUcTsIVTYNALPnTCYgDcSSn5+ldtIykJP26hrPZFoBpqlpWRNaDNWfa5411pz LfLoYfuNbvuP+378IYFDXwJ60tLNCJKMwO52FB/wxvbaLfENCw9sS0GCfk9dfGOh+OWF zjDjK2X8DmCFn/Ifal5rtYPoCrVCuAuNgnfLNLH+L0n3yMt0yZlVlvs4DNU/rQjMXXjF xeaDqhJtmevXLtGUFPkVPUI1VEj1k/LG4q+J7Y6bgTfyq78i1hrKJg3fAJW9plEQ2sSI Y5Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F1aNLl2+3U19YePXnGnea7+ZncFFGxXxaTAHdfBEBqs=; b=jfnf96WCebfaDCe1Xm93EL4ZOVFgiEIeKi6ozC7sUgsmXm/jdH+fZTB7agn5QJijn2 46Qw+KirgCjdcyK/BDhTDOi3P9wude691J7q7HcylOyuL35LaPCq29kqmHcYP5J+Vgvt dxtbT9yq0gtEZveR+IU4uplYlUvPbqtBwqR4MX+82hcVmj7R1iUqpY5SS2g8YBCD8YlT qE3PJKb0QwBop/cKetbbjyrbzZaFvs9hecx88+ddWF1OEh6MKMjNxR9iXxyVair5tkM7 Ek048PZn7hkDpeO6TCkKgyyl9EzCDOBRW8FRDpynPMNFZ+dAYVUscJl5+PCwePG3A66i d3ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Qnu+SUqF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si528812ejr.298.2020.06.29.14.57.25; Mon, 29 Jun 2020 14:57:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Qnu+SUqF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404682AbgF2V4Z (ORCPT + 99 others); Mon, 29 Jun 2020 17:56:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:56890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbgF2Sfb (ORCPT ); Mon, 29 Jun 2020 14:35:31 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5391B24688; Mon, 29 Jun 2020 15:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593443984; bh=B6B7CbmE1beGD7a0XoTWkaxDA7EpKHPavxaZ8XF46Fo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qnu+SUqFuA5dU8DNBa4oZ8bctBrdorWb5RuEAUSvJht2ljfaoD0Rm5Ejp1rG3qZ0m na/oRj5n2w3/tOlBEfKpcea+uZDkdUs5uMRe5uaX50eCkzsqs6+jKMlAJRJLTvmPxj kEdjBhKA7a/Ea9Lj+WhL3UPUxPiTox8GdQaVRUFc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Joakim Tjernlund , Oliver Neukum , Greg Kroah-Hartman Subject: [PATCH 5.7 089/265] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip Date: Mon, 29 Jun 2020 11:15:22 -0400 Message-Id: <20200629151818.2493727-90-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629151818.2493727-1-sashal@kernel.org> References: <20200629151818.2493727-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.7.7-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.7.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.7.7-rc1 X-KernelTest-Deadline: 2020-07-01T15:14+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joakim Tjernlund commit 03894573f2913181ee5aae0089f333b2131f2d4b upstream. USB_DEVICE(0x0424, 0x274e) can send data before cdc_acm is ready, causing garbage chars on the TTY causing stray input to the shell and/or login prompt. Signed-off-by: Joakim Tjernlund Cc: stable@vger.kernel.org Acked-by: Oliver Neukum Link: https://lore.kernel.org/r/20200605105418.22263-1-joakim.tjernlund@infinera.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/cdc-acm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index f67088bb8218b..d5187b50fc828 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1689,6 +1689,8 @@ static int acm_pre_reset(struct usb_interface *intf) static const struct usb_device_id acm_ids[] = { /* quirky and broken devices */ + { USB_DEVICE(0x0424, 0x274e), /* Microchip Technology, Inc. (formerly SMSC) */ + .driver_info = DISABLE_ECHO, }, /* DISABLE ECHO in termios flag */ { USB_DEVICE(0x076d, 0x0006), /* Denso Cradle CU-321 */ .driver_info = NO_UNION_NORMAL, },/* has no union descriptor */ { USB_DEVICE(0x17ef, 0x7000), /* Lenovo USB modem */ -- 2.25.1