Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3085571ybt; Mon, 29 Jun 2020 15:00:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFYHZlDYX4+JAzWStfEbg1h6P1MJq1fjep+QGiWWgGdDbea8nhqF8kBMUAASwEbPYHxZrs X-Received: by 2002:a50:fe16:: with SMTP id f22mr12918478edt.315.1593468002128; Mon, 29 Jun 2020 15:00:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593468002; cv=none; d=google.com; s=arc-20160816; b=rQdNRVZ+WgfRl/Zn70cL4v91S8mBggnDyzppgattAiV8Nedee2ta7gKXB/D0d85Boe ckRhcmAlJDYB1rKFbaPl/wV69c50ALTy2o/PAw/IZ0rUAwSWu8wPFdImgCHR8dZfSvJV 4V5U8BJ27XcpjvFyrm249Oj9Gdag5n9/ErWpLvyQozV1pO+tMozolK8bWe6r9PEUoUQq nQGVf8yqRouwYy6iE2UisbwwhpoP7dkycPuTZoCJUq/KP6v0+N1jwMqo9OFGeNM2Upws KdVv/yBVyuL1vm01rNvpyi3FOQJef/QROzmxzdo1rABUliVTwl03A+dPq2Yj+Zb9cWAo DFIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Mo42RK+W2Tr6JAO6h4yITGDHZYp6SgXtms0EGVnuuzc=; b=v4Y+hMaB6XGwBT6uo6OtQ+wTh1Yd2PpsbLUqTHH5k5Wx7EGpHNT3v+lT2CWKVdCOhJ WKuxtaxnG/+sk1lvJ/hmGs5On0t/W2zBv/SUFX446vM+V23msmnNQ0ifTrI0Eev5TZ/n q64noy8VMhhMbZSDyWfQuB/5rRjIKeDkJZ4GVOrSDQ0qUh2lpLOdJ1ohhbotW84py1uf So0cdY6baYUN7C/fHFsRccNdMjk46ELL7ztXngd+oxI0psQiPciyRYlBuzDUh8D/Y63J uJEX1hJg+oF2TMoQR48reHn5Ct8e3C0RAN8wg9Iu32sgfKWOktmRplnGuZ8kz6ecHTrh cJYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BVLuYzJM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yd6si496094ejb.326.2020.06.29.14.59.39; Mon, 29 Jun 2020 15:00:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BVLuYzJM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391654AbgF2V62 (ORCPT + 99 others); Mon, 29 Jun 2020 17:58:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:56764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbgF2Sf2 (ORCPT ); Mon, 29 Jun 2020 14:35:28 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B2502470C; Mon, 29 Jun 2020 15:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593444046; bh=eV4yzH1kV06Q930UvXCrqcVEPU1VE5C1RQqvoOt3gSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BVLuYzJMhxR6Dz8rd0avqTRAAQFO0ATSiZ9ze6PqWDqczH4JApIL+xyGd4BAKm+Pn ep4EkJhwkmTGb3UfhWuQ7gxCkUG0+9pHk8ky7zhHQh6OJyvC1VQJC4Cr7TKuvbZrsR o+3Q8lnSWXnW02Qx9F5LdEJHsnxcDPZzYObFP5C4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Lobakin , Igor Russkikh , Michal Kalderon , "David S . Miller" , Sasha Levin Subject: [PATCH 5.7 153/265] net: qede: fix use-after-free on recovery and AER handling Date: Mon, 29 Jun 2020 11:16:26 -0400 Message-Id: <20200629151818.2493727-154-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629151818.2493727-1-sashal@kernel.org> References: <20200629151818.2493727-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.7.7-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.7.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.7.7-rc1 X-KernelTest-Deadline: 2020-07-01T15:14+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Lobakin [ Upstream commit ec6c80590bde6b5dfa4970fffa3572f1acd313ca ] Set edev->cdev pointer to NULL after calling remove() callback to avoid using of already freed object. Fixes: ccc67ef50b90 ("qede: Error recovery process") Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qede/qede_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 51bb5866a212c..26eb58e7e0765 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -1247,6 +1247,7 @@ static void __qede_remove(struct pci_dev *pdev, enum qede_remove_mode mode) if (system_state == SYSTEM_POWER_OFF) return; qed_ops->common->remove(cdev); + edev->cdev = NULL; /* Since this can happen out-of-sync with other flows, * don't release the netdevice until after slowpath stop -- 2.25.1