Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3085723ybt; Mon, 29 Jun 2020 15:00:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0Q0NM6aWY7GpHQOwu7rjN6j8P1HUxPZU/uFbFEFVzprspU9+xdw0drOzeuvEwiunK7K+u X-Received: by 2002:a50:f01d:: with SMTP id r29mr19941483edl.158.1593468015277; Mon, 29 Jun 2020 15:00:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593468015; cv=none; d=google.com; s=arc-20160816; b=vIHmS8H36DDlN+0/cAuPaZoOsZXXdeUKNdiI7R+c8AvXFffoIc52SWL2XO0MRgSfW3 1w3i1tQEcharreF0zoezapppm+rdiKbgj5htOphLDTref5907ZBpgM6pF2hWcafD82l2 NgjGYqi+/MCFE0XmYvTUjNLh+N2HL82wscHVAOI+zFQSJGZanm8EgbyeiwG1W2Exws3f 4IGQdMAOjygQVnQY/xyL/5KPr8viUBDEhmwRljA1V7CKYrryraG0v1QTvDmaJPBCWSbj JvDYheRKpfmIBD3jiTQRk/dOKRPK8N/NNteDgz4d7VQuiBnbtqy8f3iTySJB0KQLnmJq uaUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=d+vLD2sjVO7AOmhqcZPi6qESJ31zaohyHK9D2GpTq08=; b=rfaePlxaCExvNosM4IVCF9u6BZG/bgiS6iLuG3FEkls5SUMCtulkxcqIlGbMeB4J6a cjc/T2XrrtE1DlFqNX9PAAAfLycV5WLjdSymETZdr7X4prXlYgW00I+DRH2IGdIcmzlG iDgy+6zYp6qgO1pf4hrm0e690vz+uIUJUC8NTIEIYwbp6Ldalcdln/HXGSNBNVdrCsuu jvO5LOr3t7n7F1mWWNaaYQN7z+ipgvM5VApyD05dKEY5agbRYr7OZJUxyP2qFFyh/ktI 54yG76TQdmDhkFX/Bsmj3UI4rIwv6OdWhMpiOH+nOqidsJWzUq4cBUhxWJ2TCkKDJojs ceDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iIVxnAOj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z14si559172ejw.332.2020.06.29.14.59.52; Mon, 29 Jun 2020 15:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iIVxnAOj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404184AbgF2V6n (ORCPT + 99 others); Mon, 29 Jun 2020 17:58:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:56792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbgF2Sf2 (ORCPT ); Mon, 29 Jun 2020 14:35:28 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79DBB246E7; Mon, 29 Jun 2020 15:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593444031; bh=PPoFicczah2+Cv9aeNEK0ooYF25MkmA+rcIgIUfURK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iIVxnAOj69spV+TCQt7YpGQcqn9cMhl3ExzFN1f3Z9ehTViP0zKn9Fy9XWyA06JUG ayd/KZHoHC+DrRwF7BMix0IPJF5swy30mfSw3UtXRnpEJbpUwj9IWFvOD6T6y29iDO 5uzhK8TC+eDsD3QnP8+hW4t/QtCL8CRppPWnfREc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Fan Guo , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.7 138/265] RDMA/mad: Fix possible memory leak in ib_mad_post_receive_mads() Date: Mon, 29 Jun 2020 11:16:11 -0400 Message-Id: <20200629151818.2493727-139-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629151818.2493727-1-sashal@kernel.org> References: <20200629151818.2493727-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.7.7-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.7.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.7.7-rc1 X-KernelTest-Deadline: 2020-07-01T15:14+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fan Guo [ Upstream commit a17f4bed811c60712d8131883cdba11a105d0161 ] If ib_dma_mapping_error() returns non-zero value, ib_mad_post_receive_mads() will jump out of loops and return -ENOMEM without freeing mad_priv. Fix this memory-leak problem by freeing mad_priv in this case. Fixes: 2c34e68f4261 ("IB/mad: Check and handle potential DMA mapping errors") Link: https://lore.kernel.org/r/20200612063824.180611-1-guofan5@huawei.com Signed-off-by: Fan Guo Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/core/mad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index f7626ebcf31cf..049c9cdc10dec 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -2941,6 +2941,7 @@ static int ib_mad_post_receive_mads(struct ib_mad_qp_info *qp_info, DMA_FROM_DEVICE); if (unlikely(ib_dma_mapping_error(qp_info->port_priv->device, sg_list.addr))) { + kfree(mad_priv); ret = -ENOMEM; break; } -- 2.25.1