Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3088133ybt; Mon, 29 Jun 2020 15:03:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwctjW2vhf3fa9lLTgoRzJV581/77FXEdU28kQHovBJshM7wps8jkRIubL53c8v34FQlrVZ X-Received: by 2002:a05:6402:c82:: with SMTP id cm2mr7967369edb.293.1593468198733; Mon, 29 Jun 2020 15:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593468198; cv=none; d=google.com; s=arc-20160816; b=umUDc3glfEz9/JvBzOYq7Iql/vtTeXIgPdCJMZjFqYBIgncUylMBaFNyaY6qY7dMOo jdMIcICOfyqeVZBane0Sg2ZKcbNdCmjy+135S81Zhl/006w51rv3xPqOS2fgS1rvwZXJ LPkbeavwRktldpcTPcTIVLbI3hb2WXATaHaYOweD24ck9PP+m9vnli61VlExT2VnanZW /GyWOhB6HJHUe0sfFUEFjdm7valPP4w7ei3HfhlPp7lwwApBahGmQThrJ8YyaTWNvrop 0/oBP4VEKarBimQg7Tune9eGZY78pNvYVMFXTb+I/ZPkf0l7FdhGlafzKIgvjgmv+bmK KC2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=v/KUmmRiKcWgfKCyfnFrzAagW5p/jFMXIxMzqZIoYfY=; b=WC75RkiQAzZQZmsV6kJo83HfchzRtmin1Vn/w0Rg2N/aqrOt7WkkZGjn2D5b4bl9N/ tTj8nirTEVEWqOFcHxDUqORgzNqvXSAMN762oSeHuIzNEKUU3F/F8E2SI/J6FC8bo65P +dIAKd548sXi9cSxrpI2to6ic1AETzT5Z+BDw6qrkQNHXUpwmHJYGdboe/C9As1ihphP la+/5lkf1+mhdJkmaTL9ogdwIDEEiYtxspHlfxlvaS0GbBg9slS5jcsQgqnZ2aQhrVme VfNcif/5e81NXH1oj9WpzWaMtzR1mtmQ1tqgAF59l42bzD7H0QbClViY72UJR/WsFQVf qxgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h16si564349ejb.456.2020.06.29.15.02.55; Mon, 29 Jun 2020 15:03:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404859AbgF2WBW (ORCPT + 99 others); Mon, 29 Jun 2020 18:01:22 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:39879 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404855AbgF2WBU (ORCPT ); Mon, 29 Jun 2020 18:01:20 -0400 Received: by mail-io1-f68.google.com with SMTP id f23so18885604iof.6; Mon, 29 Jun 2020 15:01:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v/KUmmRiKcWgfKCyfnFrzAagW5p/jFMXIxMzqZIoYfY=; b=LupuPoV2llzNCorpeUSvpgFPVCw3uXTLJRUjtxM8QiPHMyhv/6qkYn+TzcCncAcCpx UafSf++EOIHmUWlcdZpX81j6WZhabkuKamfO5ErnoK5q0QcV8G3ffMVjMnZihZbtruKw XhA7ku96rIvktauHY2V0iaL9AjGSjyeTPP1MmTDnulxAn8Zwzv0IGpJkyqL9mn2GfojT kYIY91T68/Yswbg8zQM/sRD0mDGIRzajK2rwLfokSHRriYfcQvu9FmvIdGeqlxKWUfU5 dW8kPBi4wyRbhMPi9WGLzA/c/+nKedqOOVNfDKPJLD3wKn3ysJvJ6brxT7an73EhM+MZ bk1g== X-Gm-Message-State: AOAM531u69pQsssKPUcNz2OT5bkaI/rz0lWZbPPbXXLJu2FKcJPJdpA0 HypcAHE4jwmPAD50JmFJpA== X-Received: by 2002:a02:7818:: with SMTP id p24mr20445841jac.131.1593468079258; Mon, 29 Jun 2020 15:01:19 -0700 (PDT) Received: from xps15 ([64.188.179.255]) by smtp.gmail.com with ESMTPSA id v62sm668402ila.37.2020.06.29.15.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 15:01:18 -0700 (PDT) Received: (nullmailer pid 3012987 invoked by uid 1000); Mon, 29 Jun 2020 22:01:17 -0000 Date: Mon, 29 Jun 2020 16:01:17 -0600 From: Rob Herring To: Sungbo Eo Cc: linux-gpio@vger.kernel.org, Rob Herring , Bartosz Golaszewski , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v2 2/2] dt-bindings: gpio: Add bindings for NXP PCA9570 Message-ID: <20200629220117.GA3012245@bogus> References: <20200625075957.364273-1-mans0n@gorani.run> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625075957.364273-1-mans0n@gorani.run> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jun 2020 16:59:57 +0900, Sungbo Eo wrote: > This patch adds device tree bindings for the NXP PCA9570, > a 4-bit I2C GPO expander. > > Signed-off-by: Sungbo Eo > --- > I don't feel I can really maintain this driver, but it seems all yaml docs > have a maintainers field so I just added it... > --- > .../bindings/gpio/gpio-pca9570.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dts:21.13-26: Warning (reg_format): /example-0/gpio@24:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/gpio-pca9570.example.dt.yaml: example-0: gpio@24:reg:0: [36] is too short See https://patchwork.ozlabs.org/patch/1316796 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.