Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3088989ybt; Mon, 29 Jun 2020 15:04:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxP8DxYZFnEKXxl7+uIX0I2e5qzBgx63efrvVRu4lD0RHEEA8DFutlPnwHDgrR3p83fY0eE X-Received: by 2002:a50:e791:: with SMTP id b17mr20816124edn.366.1593468269544; Mon, 29 Jun 2020 15:04:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593468269; cv=none; d=google.com; s=arc-20160816; b=OPxThCmXhvcBb0wItGjqYCtfl7zz6/SZ5pGO61QEtRiJ6bdKJP9JBLDCsmEYgnYEx6 30fQRrgJWumiQtg1YZsOJhhZRS44ZcnpWOEOXqJ8pu0N9pYhvYZEy1sgZJT629PWb43T wFNNh8LpSyjII96sBEEPMboMsVlXHnhfkbxhELgeTv2gNJ9IJ4aWJuJkO5MLggRi4Vu8 ygngwcp3YLp1ilQA1ZRTx9rqKKd36uOa8o/9Ul+UEuBPj5XA7JXZFc36taAEuMdUJp83 uQeejxoYGqlWJgbM1iYnNskyPKVfil3o9s09VvzCv8wBUMahjBqqJi2WSK2PD/+/Hvic nxQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AeMZ7oStxlWxNqg0rIvb/f3QjjNKEBA+23CJ4jcs2Dk=; b=EbUOX/y1l3Ucy983t2ylaaaAq8GUjWuxQNnym6/UBNKWrvWVmEieWdNSYQjbepWJks I7lCbtZH3+WY8qHmLhFwRewSUVJb+yrfFk6osg478CsMQKEmtH0/z3Pb1nFBtr4EDsgW A4iJGMfB/gLXQlYh36QRON6X7c0kDZfRv6yqmBJb+SpjgFMf+JQ9L/j1Pa6Ob6mlxyBz +kSKZBj0hWRMKGIXDqtRKsZEj5KqycBdJniIxPvU+povQtg0qSscIDbuvhHDQnUHPckI F+g36WCuMjgpuJBF5a/oGnOBBqp0DHlGykvJXSzAa+BLy4HilAZMv6q42ONcQup4heLb Bwww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=g8ig4Y83; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i23si495064eds.82.2020.06.29.15.04.06; Mon, 29 Jun 2020 15:04:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=g8ig4Y83; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730234AbgF2WCb (ORCPT + 99 others); Mon, 29 Jun 2020 18:02:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:56762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726284AbgF2SfX (ORCPT ); Mon, 29 Jun 2020 14:35:23 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A4D62472F; Mon, 29 Jun 2020 15:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593444051; bh=APLxcwDGeZ9hfuIkU4SGCga+WTEhWX0SpFSyYDeFI1k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g8ig4Y83z+1wb0hF4vLiDUraL+Kv6Cvl2yzzTIChtUdIpAL7OQvAVHOYpf/JB+JSs miLgvs1iFTKl9nHFvykJuBbgV8wkRxt7lWd77bk8KESvOOnPWDca/M8RVjUPzr9/gN 35hnCGs8AHcu2T82L5m6gLkNLGFpb66bPDBME5Ek= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Felipe Balbi , Sasha Levin Subject: [PATCH 5.7 159/265] usb: gadget: udc: Potential Oops in error handling code Date: Mon, 29 Jun 2020 11:16:32 -0400 Message-Id: <20200629151818.2493727-160-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629151818.2493727-1-sashal@kernel.org> References: <20200629151818.2493727-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.7.7-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.7.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.7.7-rc1 X-KernelTest-Deadline: 2020-07-01T15:14+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit e55f3c37cb8d31c7e301f46396b2ac6a19eb3a7c ] If this is in "transceiver" mode the the ->qwork isn't required and is a NULL pointer. This can lead to a NULL dereference when we call destroy_workqueue(udc->qwork). Fixes: 3517c31a8ece ("usb: gadget: mv_udc: use devm_xxx for probe") Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/mv_udc_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index cafde053788bb..80a1b52c656e0 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -2313,7 +2313,8 @@ static int mv_udc_probe(struct platform_device *pdev) return 0; err_create_workqueue: - destroy_workqueue(udc->qwork); + if (udc->qwork) + destroy_workqueue(udc->qwork); err_destroy_dma: dma_pool_destroy(udc->dtd_pool); err_free_dma: -- 2.25.1