Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3092702ybt; Mon, 29 Jun 2020 15:09:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3j34+BGjQsBZe2MZ9nqzuvUh06jYkf1z0Um5FPHj41/aXPfV77kF/J7tM5MtNcnuw/puI X-Received: by 2002:aa7:db57:: with SMTP id n23mr19557951edt.235.1593468590459; Mon, 29 Jun 2020 15:09:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593468590; cv=none; d=google.com; s=arc-20160816; b=gqV2rBsA9FCc2Ni6Wk5WWLfMq3xnafVAVcYV5CNgZJgSrswF/58XdrWOZATucfzzIN MwPPpiDwFADDKYiVjkFqpMOomxRSHsXeECRxyTblPWO3E8sdRm4m5sviUxtSfOSkSfwY ywL5ofMIHL8h7/Gu7jU990vx7swgpAW4SrpzheMss7V7jsjaG58im5V51gxDa4JBWL8U mhMmYRmj6Reu1sxzSGVmfVjjg2UiMKggFh+jwPpKTc7LF0KmFolEmSR4rYf5kRMOKOtp yEBuaQncp3vAcuTTmdX4r+lUdZyGWriaA1hvLzmd+AldDjwjBa1Zfo0rggLQXF5Wy82A 88/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=3PG5b5N+dKKe0m65hv0fCpoauQICQwYsngU0ryEgWA8=; b=l06VUEnOTB7m59N5mi4xziHSuEQ19f/smxE1ltUgNOOXL69RK7VzrI+LDlywLVwQQv khYp2N0lWXuXOOQe+JYS439Qp85SFQjqsd9MziQR4uKHXTIQ5EcqsmGA6af9+IgzZAr8 GJWXawKxCdnTPrcNxUHBewzfHeYUNqDfuYQ3gn2naw1htHcDKpjMYUNJS0qwBCsMTur4 1slAmsjHdKWhsC8pvsOxik3ircfWrmg7PZUlMDx0RCwjlKjx861O8mNgdHOMcoDBW6P8 sjcbXiSfO62xVOku8HMf7/kRPZsskApIxZW426Xb0uGl1NJ9LNYy03hnCOHuBxUBDxGx b5Kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j13si526929ejc.314.2020.06.29.15.09.27; Mon, 29 Jun 2020 15:09:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391917AbgF2WGm (ORCPT + 99 others); Mon, 29 Jun 2020 18:06:42 -0400 Received: from muru.com ([72.249.23.125]:59940 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbgF2SfO (ORCPT ); Mon, 29 Jun 2020 14:35:14 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 590AB81C2; Mon, 29 Jun 2020 18:27:18 +0000 (UTC) Date: Mon, 29 Jun 2020 11:26:22 -0700 From: Tony Lindgren To: Lee Jones Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND 07/10] regulator: cpcap-regulator: Remove declared and set, but never used variable 'ignore' Message-ID: <20200629182622.GC37466@atomide.com> References: <20200625191708.4014533-1-lee.jones@linaro.org> <20200625191708.4014533-8-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200625191708.4014533-8-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lee Jones [200625 19:18]: > It's okay to not check the return value that you're not conserned > about, however it is not okay to assign a variable and not check or > use the result. > > Fixes W=1 warnings(s): > > drivers/regulator/cpcap-regulator.c:172:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable] > 172 | int error, ignore; > | ^~~~~~ > drivers/regulator/cpcap-regulator.c: In function ‘cpcap_regulator_disable’: > drivers/regulator/cpcap-regulator.c:196:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable] > 196 | int error, ignore; Acked-by: Tony Lindgren