Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 29 Jun 2020 20:52:09 -0300
From:   Bruno Meneguele <bmeneg@redhat.com>
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        erichte@linux.ibm.com, nayna@linux.ibm.com
Subject: Re: [PATCH v3 1/2] arch/ima: extend secure boot check to include
 trusted boot
Message-ID: <20200629235209.GB2756@glitch>
References: <20200623202640.4936-1-bmeneg@redhat.com>
 <20200623202640.4936-2-bmeneg@redhat.com>
 <1593202992.27152.463.camel@linux.ibm.com>
MIME-Version: 1.0
In-Reply-To: <1593202992.27152.463.camel@linux.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="61jdw2sOBCFtR2d/"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--61jdw2sOBCFtR2d/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 26, 2020 at 04:23:12PM -0400, Mimi Zohar wrote:
> On Tue, 2020-06-23 at 17:26 -0300, Bruno Meneguele wrote:
> <snip>
>=20
> > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima=
/ima_main.c
> > index c1583d98c5e5..a760094e8f8d 100644
> > --- a/security/integrity/ima/ima_main.c
> > +++ b/security/integrity/ima/ima_main.c
> > @@ -694,7 +694,7 @@ int ima_load_data(enum kernel_load_data_id id)
> >  =09switch (id) {
> >  =09case LOADING_KEXEC_IMAGE:
> >  =09=09if (IS_ENABLED(CONFIG_KEXEC_SIG)
> > -=09=09    && arch_ima_get_secureboot()) {
> > +=09=09    && arch_ima_secure_or_trusted_boot()) {
> >  =09=09=09pr_err("impossible to appraise a kernel image without a file =
descriptor; try using kexec_file_load syscall.\n");
> >  =09=09=09return -EACCES;
> >  =09=09}
>=20
> Only IMA-appraisal enforces file integrity based on policy.
>=20

Right, but I didn't get the relation to the code above: I basically
renamed the function:=20

"arch_ima_get_secureboot" -> "arch_ima_secure_or_trusted_boot". =20

Which doesn't change the ima_load_data logic.

--=20
bmeneg=20
PGP Key: http://bmeneg.com/pubkey.txt

--61jdw2sOBCFtR2d/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEdWo6nTbnZdbDmXutYdRkFR+RokMFAl76fqkACgkQYdRkFR+R
okMSCwf6ArclPVwGnMxzR1YUkXqbk98vyQn1q7ARf7mcpdWpVdzicAwiacFuaAMP
3uHozsXFja1TneJZpKj8ZI+noUFiHxL4G3s560qNfaIyr7eqOUd7ptKfzP1RW/5+
C049uTjHMTe38EhUtq3sG+YkBSo3NLz1e/O78eBW++44fOAqqrGyKKrJPyrmqMTx
/ieLpcfGrY9rnNtGm+pvcGWQntT0J2kddg2oxYB1JBRdbPBOXFYzfpTqQZRo1DP6
AscFZaSpcnlLgAMXr0J0TsLhaZZ4+FINhGYNRUc1R3nN1IwM0UdMWqXHi6qMW0aU
sB8+pxFQlSYmWeZGwrWZj4AKQeulYA==
=jCqQ
-----END PGP SIGNATURE-----

--61jdw2sOBCFtR2d/--