Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3147140ybt; Mon, 29 Jun 2020 16:53:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjKPjl+TdyJrCgVoQn54Drwnv68Lgg0piiQZv4n6LBkxh+ZtJnajDsYxfvA8g/FLAZ7YO5 X-Received: by 2002:a17:906:6146:: with SMTP id p6mr10487380ejl.433.1593474798289; Mon, 29 Jun 2020 16:53:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593474798; cv=none; d=google.com; s=arc-20160816; b=Wc0UrLPrWJ1xUrCEBqC+sROc4TKy35geVLw950eG94sM0GMMHzuDz3hoTN0zFrnl4r Ov03EwudEY4vQCGobV+0OAXvUzr6LO7LNxvWJKaDQWSMBivjWd3HqO5nG+r/T021dxzx 1qCVrWDN4wBijg1G5ufpMDV8uJ9QjHwdvtdpVKWahMaKVpuX1W8/d9XsEVyEdoWNsITd Gg15aLtNhLR4rOO0Fl67q4qtfB776YTU/Y1ilBdI0habcF/wYF7k8g4rdmtZMdplURNj DSg8pacMrMVcitFoW7w71elkssFD1BEFYRoJfXMTutm/VTl0uKEdQHLQkR9vIeabzLr7 kEBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=io2izBrpIb6zBpyiqnJk+LDnBcqzO6El7soSuFrAlAI=; b=T9Edwd0EKPGoXBF82THKPe4bIvEdXu9PEXjoznmA7yHtRRUEvwB908nEKZnU4PbXzK P2TetxM7/dvZ7FOhmgx4e0pNSzQoMQ5e4Cl6IRIN6evvUhcJ+F3xR/VHy8/R06eb0IPZ YC2y/goVVLZVfq1uM21rJXmLFsXOn3hwJM29fc8sCeUgeQQzPrtIzPSqBXh4n7+6h/Vi nkAuz0D3soUsP7f/TvFEfd7hBXzI8sK0wDv+yRhq05CwmFKrUewNDl78RZvz4B5N+vzF O2jmN837gLMV05F53vChOVTk4i6jm7TFfxR3x0CcHZhcJAd1N3gSqwZPVIT22Pmwt+Xo O0Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hh3si778170ejb.490.2020.06.29.16.52.55; Mon, 29 Jun 2020 16:53:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728180AbgF2XqB (ORCPT + 99 others); Mon, 29 Jun 2020 19:46:01 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:55510 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726751AbgF2XqB (ORCPT ); Mon, 29 Jun 2020 19:46:01 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 543F54E9FF7E02924904; Mon, 29 Jun 2020 16:00:09 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 29 Jun 2020 16:00:07 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: remove useless parameter of __insert_free_nid() To: Liu Song , , CC: , , References: <20200628134813.37192-1-fishland@aliyun.com> From: Chao Yu Message-ID: Date: Mon, 29 Jun 2020 16:00:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200628134813.37192-1-fishland@aliyun.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/6/28 21:48, Liu Song via Linux-f2fs-devel wrote: > From: Liu Song > > In current version, @state will only be FREE_NID. This parameter > has no real effect so remove it to keep clean. > > Signed-off-by: Liu Song Reviewed-by: Chao Yu Thanks,