Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200629012524.c941a5f18aa7f312d325f714@kernel.org> <mhng-37e70bbc-2616-41e6-bc8a-f144ca647c97@palmerdabbelt-glaptop1>
In-Reply-To: <mhng-37e70bbc-2616-41e6-bc8a-f144ca647c97@palmerdabbelt-glaptop1>
From:   Guo Ren <guoren@kernel.org>
Date:   Tue, 30 Jun 2020 08:12:41 +0800
Message-ID: <CAJF2gTQ-LcZ_fxTCkHNBYqZn-C-QVeLp12FysaTjPe6PuTQYxg@mail.gmail.com>
Subject: Re: [PATCH V2] riscv: Fixup compile error BUILD_BUG_ON failed
To:     Palmer Dabbelt <palmerdabbelt@google.com>
Cc:     Masami Hiramatsu <mhiramat@kernel.org>,
        Greentime Hu <greentime.hu@sifive.com>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Anup Patel <anup@brainfault.org>, linux-csky@vger.kernel.org,
        Zong Li <zong.li@sifive.com>,
        Guo Ren <guoren@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Palmer,

On Tue, Jun 30, 2020 at 7:22 AM Palmer Dabbelt <palmerdabbelt@google.com> w=
rote:
>
> On Sun, 28 Jun 2020 09:25:24 PDT (-0700), mhiramat@kernel.org wrote:
> > On Sun, 28 Jun 2020 16:07:37 +0000
> > guoren@kernel.org wrote:
> >
> >> From: Guo Ren <guoren@linux.alibaba.com>
> >>
> >> Unfortunately, the current code couldn't be compiled:
> >>
> >>   CC      arch/riscv/kernel/patch.o
> >> In file included from ./include/linux/kernel.h:11,
> >>                  from ./include/linux/list.h:9,
> >>                  from ./include/linux/preempt.h:11,
> >>                  from ./include/linux/spinlock.h:51,
> >>                  from arch/riscv/kernel/patch.c:6:
> >> In function =E2=80=98fix_to_virt=E2=80=99,
> >>     inlined from =E2=80=98patch_map=E2=80=99 at arch/riscv/kernel/patc=
h.c:37:17:
> >> ./include/linux/compiler.h:392:38: error: call to =E2=80=98__compileti=
me_assert_205=E2=80=99 declared with attribute error: BUILD_BUG_ON failed: =
idx >=3D __end_of_fixed_addresses
> >>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER=
__)
> >>                                       ^
> >> ./include/linux/compiler.h:373:4: note: in definition of macro =E2=80=
=98__compiletime_assert=E2=80=99
> >>     prefix ## suffix();    \
> >>     ^~~~~~
> >> ./include/linux/compiler.h:392:2: note: in expansion of macro =E2=80=
=98_compiletime_assert=E2=80=99
> >>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER=
__)
> >>   ^~~~~~~~~~~~~~~~~~~
> >> ./include/linux/build_bug.h:39:37: note: in expansion of macro =E2=80=
=98compiletime_assert=E2=80=99
> >>  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> >>                                      ^~~~~~~~~~~~~~~~~~
> >> ./include/linux/build_bug.h:50:2: note: in expansion of macro =E2=80=
=98BUILD_BUG_ON_MSG=E2=80=99
> >>   BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
> >>   ^~~~~~~~~~~~~~~~
> >> ./include/asm-generic/fixmap.h:32:2: note: in expansion of macro =E2=
=80=98BUILD_BUG_ON=E2=80=99
> >>   BUILD_BUG_ON(idx >=3D __end_of_fixed_addresses);
> >>   ^~~~~~~~~~~~
> >>
> >> Because fix_to_virt(, idx) needs a const value, not a dynamic variable=
 of
> >> reg-a0 or BUILD_BUG_ON failed with "idx >=3D __end_of_fixed_addresses"=
.
> >
> > Looks good to me :)
> >
> > Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Is there a configuration that runs into this bug?  It's not showing up fo=
r me,
> and I generally try to add regressions to my test suite.
>
> > Thanks!

KPROBE, I'll send the patch soon.

--=20
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/