Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3289467ybt; Mon, 29 Jun 2020 21:52:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtZzT/5xp028fgFsKQ8K+0Nk2tx1Lz1wlDaesGqKvA1TXOwhu+1uAnilq2QQy53w9JNON3 X-Received: by 2002:a17:906:7694:: with SMTP id o20mr16611618ejm.289.1593492740651; Mon, 29 Jun 2020 21:52:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593492740; cv=none; d=google.com; s=arc-20160816; b=c1ZYYYYcbVBYKz47p9ZHdlG58FELmd7vZqk7fogn5Qr++q8jyjgfbrc0ekhEk6Ngh1 1gkeONI7dypuVInggGQMB3EBW5oNIWwkm516iP0iL2gvuIe9CEdGuj5MulHvsPxM4+no LvpJ5mG3YWMsWGYnr2ydmo2vMyCA/fe7ryQfvQJD3BXR4eT0T+fcSlcLzkzZxkKhYEUk zgDSseZQJuU6bmDKxz/tQhsKREOnJuff9owXkGk81p7QKYL73bmt+qo+fsvtrf0tXChP 0aGwATXT13jSxg40JNMvsFlQY/6qBVhVjsa4exeUp/2mgw4zHzQYZmb+9yCiGod6NPW3 SeCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=zCaps0loQaEmR/b2P5B3LXujzdso5k67v4HcTYc+GR8=; b=n8efiW6vPESTXI2fCjVNzdLqgWYMH+n1sKu2kzZujFoiSIUx/tLd/SKnHfW4Vutacz T9hvDn6hHlc2lk5UUMESyTMJkupVv8dEnx66Xf5aSmh27qRrTm52/T9QvSOU6pKciWDY FhFSGYl0g2G3Az4yBxlKDuYioKS36oPSKITTjwAd3x3KfiGiHPfDK7UC64MepYcJqhrV CD+ACcTrZ1a3232mcjH4gWdsoSFMbNYzufyZ8QpkPjlzqkemFC40HZ/zyJRvFc/kCiN3 BOZORBnSf2kDJfTwsdPU6pwQrZQIeOW9SRov2dFI0zoSdhIchidiVRabTKC4UJNvvxw+ gvWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=SzPJFfIc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c25si936155edw.141.2020.06.29.21.51.57; Mon, 29 Jun 2020 21:52:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=SzPJFfIc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729548AbgF3EvM (ORCPT + 99 others); Tue, 30 Jun 2020 00:51:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728909AbgF3EvL (ORCPT ); Tue, 30 Jun 2020 00:51:11 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A51F0C03E979 for ; Mon, 29 Jun 2020 21:51:11 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id z63so17436477qkb.8 for ; Mon, 29 Jun 2020 21:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zCaps0loQaEmR/b2P5B3LXujzdso5k67v4HcTYc+GR8=; b=SzPJFfIcOzkcEYGA5v9ELeSfWERhjHPdjUj+Nvn1dSi0ZNyXp3B5TJjdq6S8/qq6NM MObyQPupwPQ94gzOYT3piiHl/suxo+twRdybak+evrIGY2afwXFKaJg0T2TdJa+QWGbY Tu2zbOgHLVwAHmYeDTm8zzrCFZrA+V8rG9G3dt53CdRnL+F/ou52CAMIEjcJUMMgW2uY AFXgTEzAQdXPos6Zngn1kQjD4qX+FMMb6JQnuN4azoc5ArC5CeKxSSbXcAWfkFeU3xeY 7BfZKszqNNDiHTTGuFHPDefnVeq2lygo+b/kAKQuh6Yl4yTwamXJwBfOOOHKISJdJKTZ jA8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zCaps0loQaEmR/b2P5B3LXujzdso5k67v4HcTYc+GR8=; b=ueAVnySG+Y5KiWDtksaJHQVMVyhmlNGE0bp4XM3pC/mxJUg8tyBx8FA3SUrblG7vGk pAuS15Lk2EQQeRA/IExQQdhGy61VV7OizRuOXAC8MS+J3hv9v4dRJfGAUJBOth7imGcW hQHoPBCeS2NAq++AkKk9HxGgEh88J0/RL2XZw46K2hr7vgzm5mvNqQEbYztew3LLJ/7+ jkZjyzLVIDFeD+bH49VSCexDH6FQkDdPBvcJGp2YMvXOIJ8ANtYg3zkx4Hm4+H5pSr30 kaOBza6t8PNvv9YtAVlC0B8XzBbUbXIqyflFKJpwb0yR9yWYiIXrRvYZ9h06hbzfj95W 0kww== X-Gm-Message-State: AOAM530esFbS//KIa+gbWX/UcUHNEsdLkYg6qtKMDeheXUyRomD72hc/ WbkXZzR38kN1/GrKeig7z7cPJ+jWHS8to3WgyH3u0Q== X-Received: by 2002:a05:620a:1273:: with SMTP id b19mr18111737qkl.10.1593492670843; Mon, 29 Jun 2020 21:51:10 -0700 (PDT) MIME-Version: 1.0 References: <20200629211801.C3D7095C0900@us180.sjc.aristanetworks.com> <20200629171612.49efbdaa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200629171612.49efbdaa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Francesco Ruggeri Date: Mon, 29 Jun 2020 21:50:59 -0700 Message-ID: Subject: Re: [PATCH] igb: reinit_locked() should be called with rtnl_lock To: Jakub Kicinski Cc: open list , netdev , intel-wired-lan@lists.osuosl.org, David Miller , Jeff Kirsher Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Would you mind adding a fixes tag here? Probably: > > Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver") That seems to be the commit that introduced the driver in 2.6.25. I am not familiar with the history of the driver to tell if this was a day 1 problem or if it became an issue later. > > And as a matter of fact it looks like e1000e and e1000 have the same > bug :/ Would you mind checking all Intel driver producing matches for > all the affected ones? Do you mean identify all Intel drivers that may have the same issue? Francesco