Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 4uKteS3ft0b/qoHH5vZf6mopGpvd2k4pABT2Kez7Jk/GZDF3ffKAYxppDZqEHdKO0j1LcWPDzf
 CkYCeTMizuYA==
IronPort-SDR: eGGj2t6g5LUU1YhVwky6xRMNCWEVLwnbATlY9tpArRmc7dT1GHG5j1QV6jPn1Wb22N2/pWvd7O
 F2WuH6iRJGHw==
Cc:     baolu.lu@linux.intel.com, David Woodhouse <dwmw2@infradead.org>,
        Joerg Roedel <joro@8bytes.org>,
        iommu@lists.linux-foundation.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Kai Heng Feng <kai.heng.feng@canonical.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Sun, Jian" <jian.sun@intel.com>
Subject: Re: [Issue]platform/x86: iommu: System can't shutdown because iommu
 driver keeps checking the status of DMA_GSTS_TES
To:     Koba Ko <koba.ko@canonical.com>
References: <CAJB-X+Ww=bZN2qZ=e=4EkN_RUTiZxHxkdnHh50y9iVqZmT_XQg@mail.gmail.com>
 <111dde48-8018-6d74-5df8-1534143f4de6@linux.intel.com>
 <CAJB-X+WgjKR3PgoF_tn_g__+agCSGJpyB8sh+A62gs0qztDuVQ@mail.gmail.com>
From:   Lu Baolu <baolu.lu@linux.intel.com>
Message-ID: <66cacbab-b04d-33f3-053e-4d554ac7c662@linux.intel.com>
Date:   Tue, 30 Jun 2020 15:52:40 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <CAJB-X+WgjKR3PgoF_tn_g__+agCSGJpyB8sh+A62gs0qztDuVQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Koba,

On 2020/6/30 15:31, Koba Ko wrote:
> On Mon, Jun 15, 2020 at 3:20 PM Lu Baolu <baolu.lu@linux.intel.com> wrote:
>>
>> Hi Koba Ko,
>>
>> On 2020/6/15 11:19, Koba Ko wrote:
>>> hi All,
>>> I have a machine and there's only intel gpu.
>>> the secureboot and vt-d is enabled in BIOS.
>>> On the Ubuntu desktop, I do s2idle first and restart the machine.
>>> The machine can't restart successfully, so I need to press the
>>> power button to shutdown.
>>> I tried  each of the following and the issue can't be triggered.
>>> 1. disable secure boot in BIOS.
>>> 2. intel_iommu=off.
>>> 3. intel_iomm=igfx_off.
>>> 4. nomodeset
>>> 5. i915.modeset=0.
>>>
>>> After I investigate further, find inte_iommu keeps checking the status
>>> of DMA_GSTS_TES.
>>> During the procedure of restart, the driver would disable iommu
>>> translation and
>>> check status of DMA_GSTS_TES until status of DMA_GSTS_TES is 0.
>>>
>>> If you need more information, I can provide it.
>>
>> Do you mind telling what platform is it?
>>
>> Best regards,
>> baolu
> Hi Baolu,
> Sorry, i missed your email.
> I'm running on TGL.
> My colleague has reported this on bugzilla.
> Have tested your patch and it works fine.
> https://bugzilla.kernel.org/show_bug.cgi?id=208363
> 
> Could you explain more about these patches!? Why do we need  a flag
> for active iommu!?
> 

We're still investigating this issue. If we find out more, I'll let you
know. Thanks a lot for the reporting.

Best regards,
baolu