Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1591975362-22009-1-git-send-email-christophe.kerello@st.com> <1591975362-22009-5-git-send-email-christophe.kerello@st.com>
In-Reply-To: <1591975362-22009-5-git-send-email-christophe.kerello@st.com>
From:   Richard Weinberger <richard.weinberger@gmail.com>
Date:   Tue, 30 Jun 2020 11:13:52 +0200
Message-ID: <CAFLxGvzfh1Qa_gM9bZAxaoCbO6xCoNdaPN=Ea20Up_zPVgjugw@mail.gmail.com>
Subject: Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI
 controller driver
To:     Christophe Kerello <christophe.kerello@st.com>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, arnd@linaro.org,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Marek Vasut <marex@denx.de>, devicetree@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        linux-mtd@lists.infradead.org,
        linux-stm32@st-md-mailman.stormreply.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 12, 2020 at 5:24 PM Christophe Kerello
<christophe.kerello@st.com> wrote:
>
> The driver adds the support for the STMicroelectronics FMC2 EBI controller
> found on STM32MP SOCs.
>
> Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
> ---
> +       if (!IS_ERR(rstc)) {
> +               reset_control_assert(rstc);
> +               reset_control_deassert(rstc);

Shouldn't there be a small delay between assert and deassert?
Other than that the code looks good to me.

-- 
Thanks,
//richard