Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 30 Jun 2020 11:39:37 +0200 (CEST)
From:   Richard Weinberger <richard@nod.at>
To:     Christophe Kerello <christophe.kerello@st.com>
Cc:     Richard Weinberger <richard.weinberger@gmail.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, arnd@linaro.org,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Marek Vasut <marex@denx.de>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-stm32@st-md-mailman.stormreply.com
Message-ID: <1839269888.74591.1593509977137.JavaMail.zimbra@nod.at>
In-Reply-To: <e30abadc-83c0-f010-be36-fe8d14c4aea9@st.com>
References: <1591975362-22009-1-git-send-email-christophe.kerello@st.com> <1591975362-22009-5-git-send-email-christophe.kerello@st.com> <CAFLxGvzfh1Qa_gM9bZAxaoCbO6xCoNdaPN=Ea20Up_zPVgjugw@mail.gmail.com> <e30abadc-83c0-f010-be36-fe8d14c4aea9@st.com>
Subject: Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI
 controller driver
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver
Thread-Index: IyChESkmAt61iUEj3iffmldxiXkByg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "Christophe Kerello" <christophe.kerello@st.com>
> An: "Richard Weinberger" <richard.weinberger@gmail.com>
> CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>,
> "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, arnd@linaro.org, "Alexandre Torgue"
> <alexandre.torgue@st.com>, "Marek Vasut" <marex@denx.de>, "devicetree" <devicetree@vger.kernel.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "linux-mtd" <linux-mtd@lists.infradead.org>, linux-stm32@st-md-mailman.stormreply.com
> Gesendet: Dienstag, 30. Juni 2020 11:35:38
> Betreff: Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver

> Hi Richard,
> 
> On 6/30/20 11:13 AM, Richard Weinberger wrote:
>> On Fri, Jun 12, 2020 at 5:24 PM Christophe Kerello
>> <christophe.kerello@st.com> wrote:
>>>
>>> The driver adds the support for the STMicroelectronics FMC2 EBI controller
>>> found on STM32MP SOCs.
>>>
>>> Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
>>> ---
>>> +       if (!IS_ERR(rstc)) {
>>> +               reset_control_assert(rstc);
>>> +               reset_control_deassert(rstc);
>> 
>> Shouldn't there be a small delay between assert and deassert?
>> Other than that the code looks good to me.
>> 
> 
> Even if I have currently not met any issue, I will add a udelay(2) to be
> safe. It will be part of v6.

Well, if it works and you are sure, please go for it. Like I said, I'm no expert in
this.
I just noticed that other users add a delay and wondered.

Thanks,
//richard