Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200625075805.363918-1-mans0n@gorani.run> <CAMpxmJXDHX-U-HWR8093orBU1ZxEeWp_r2Xar+k5FMoZ1pS78Q@mail.gmail.com>
In-Reply-To: <CAMpxmJXDHX-U-HWR8093orBU1ZxEeWp_r2Xar+k5FMoZ1pS78Q@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 30 Jun 2020 12:53:42 +0300
Message-ID: <CAHp75VdNh8nFNqZxSD0g7ADD8GvY+Dmbfg8xc6LW94hw_Brwew@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570
To:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc:     Sungbo Eo <mans0n@gorani.run>,
        Linus Walleij <linus.walleij@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 30, 2020 at 12:28 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> On Thu, Jun 25, 2020 at 9:58 AM Sungbo Eo <mans0n@gorani.run> wrote:

> > +static const struct of_device_id pca9570_of_match_table[] = {
> > +       { .compatible = "nxp,pca9570" },
> > +       { /* sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, pca9570_of_match_table);
>
> If you're not using it in probe than maybe move it next to the I2C device table?

(Side note)
...and even if so it can be assessed via a struct device pointer:
dev->driver->id_table (don't remember by heart, but you have an idea).

-- 
With Best Regards,
Andy Shevchenko