Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3469859ybt; Tue, 30 Jun 2020 03:41:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIiEZH14cOCi/sHhPs6UvMKAnexRmQDtNtSj+4+gRDMtyLX8x40HTFbdBootec69PoPXVf X-Received: by 2002:a17:906:d9c4:: with SMTP id qk4mr18722777ejb.100.1593513714944; Tue, 30 Jun 2020 03:41:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593513714; cv=none; d=google.com; s=arc-20160816; b=YGLNxkd/uynZwb3TiDKdlt1cb5D2uPXEavLXl+Re9e5hkvZUySCmdHX1QHNOgkq3/U yG0d3aaBjx1ZkJa/Wdo5mYHxWzGp8E7291lqLRxcIDevo8x/2iLJ7mNcrJ0jnh2qnb0e r8lrO8rwnf18JniHhrEbc7exgZemd/deahiEn7x08ZOJ9GzGFmpq0Qi4Z06kqjgcG+xU 3B2wHQ9yEIp1IUNu+PUztVoT0abfZnsy8Q76LZRD4s36c+8KbWkcZMoEJH4KDRNSsaId 9YHDbGaVWjuA6pkT5nPSy/V3aigI/HmFZA4X9ZezCWqipKyKaeo+gsuZA55EL5LTKZNr ghJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ouvANLkhDJMSMWqfkAgGpEVrStSUqwRIMZvAH+8QrvY=; b=ozSH43Vy9blJFLB8EuzCspsQ3dH6xmAQjFrGktjLds3nlZp7zVP/1JHusbBrLfsxIL 7YwauI/CgBlNUR4kRObt9iLsLzBzHahe+a/nS4fz/oDpvYszR4w9GHQ9hpe9H79AkQDf tJyU1H9dttoTKk2mRssM3veexGlHi1wKlXcAxwPoRO+rs/eP9rvXcnfuhy7lTCt61api VY/LIJaE88RrVyGHIvc0S/E3l8pH546sMgU2bOtezZxDQd04YAiHW5UJuMsxzE9gwTIY HC3UD4LSPVilQKc0tCoxZ8EwLnRUBTlPlFf1DfZMVw5DJJ0u83maQN5Bj9cixr0cXSax Qt3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=N2Uz5Fpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si1383152edn.338.2020.06.30.03.41.32; Tue, 30 Jun 2020 03:41:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=N2Uz5Fpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732551AbgF3Kku (ORCPT + 99 others); Tue, 30 Jun 2020 06:40:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:55228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732417AbgF3Kkt (ORCPT ); Tue, 30 Jun 2020 06:40:49 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7EA82065F; Tue, 30 Jun 2020 10:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593513649; bh=5qvJz6IPxW4GxH4mEunu4MaN4GfIhfcEM+grEQlyTOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N2Uz5FpxOZMzl1sRgzzhtHb6mSSdB+Pa8aK8nLsqq7guqzojcCLyep/rpV8vPC0f8 GInCDAwuI4Q3Um2eBSbZbdDVn8yzsRP2GM6roG2FasbLMiXKUaHB73QHczNQNwDpGd M9tT+5mcW9a/Q56/qBGo1XMddjjNrz9vFUlGz5ic= Date: Tue, 30 Jun 2020 11:40:47 +0100 From: Mark Brown To: Yu-Hsuan Hsu Cc: linux-kernel@vger.kernel.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Cheng-Yi Chiang , Tzung-Bi Shih Subject: Re: [PATCH] ASoC: rockchip: add format and rate constraints on rk3399 Message-ID: <20200630104047.GD5272@sirena.org.uk> References: <20200630091615.4020059-1-yuhsuan@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IMjqdzrDRly81ofr" Content-Disposition: inline In-Reply-To: <20200630091615.4020059-1-yuhsuan@chromium.org> X-Cookie: Walk softly and carry a megawatt laser. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IMjqdzrDRly81ofr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 30, 2020 at 05:16:15PM +0800, Yu-Hsuan Hsu wrote: > S8 and S24 formats does not work on this machine driver so force to use > S16_LE instead. > In addition, add constraint to limit the max value of rate because the > rate higher than 96000(172000, 192000) is not stable either. What is the source of these restrictions - are they due to the component devices? If they are then the component devices ought to be setting suitable constraints themselves. --IMjqdzrDRly81ofr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl77Fq4ACgkQJNaLcl1U h9BqcQf/bBQI6UlLdBzbns/XWHMzns0NgqJqIDhyUaAV2cK/NnbvoadF7Q/Ierez Kksy56oOcNJtiTpSuhy/Z2ubQNKNkcMYkwVSp3M3FllU/QxR59Ia7N8P4xkvbOsx a5niu9cUSP94dygzita0jqcVvYkXXAaC9IHK/v11WwKsoM8KTgP3CWgksBGWJqVm uTY3zisJtV1m7GIHObSu0Vr9c6XJrCi5G9qDZSxPyq+Fhcpz6nFtA3sN7Ctu5j8J G8HdFjK69Suj6ESd13Xkd2/ELgNGzpA/W0SVpVkJzmS4Mbj6iyUegxXIk5LjVx4C XfuoMxggN8y3ux+S5/MlmEw9AqU/TA== =1Ldw -----END PGP SIGNATURE----- --IMjqdzrDRly81ofr--