Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3598012ybt; Tue, 30 Jun 2020 06:58:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVoxu7Jszk+kGR2At1sjazyVUb9m8ahShQiQ8lEFjeQKYHFaVenCaYXRqsJhSsKkRsmF5h X-Received: by 2002:a17:906:7212:: with SMTP id m18mr18258711ejk.29.1593525504730; Tue, 30 Jun 2020 06:58:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593525504; cv=none; d=google.com; s=arc-20160816; b=maYmMG93OQkGm9UIOS3hFv9qxcakhBuTyf2X0pm8UT8YzFhL4y7+KkBQLlcLIc3dDZ aqcDbwdL/nDZx+UijDbcWtZ8MvYQqe/1BhdMVLYSh7or2yQDM0CTSO3XnnSzok/z/ehW HEbDOpy9O1ApXhf23JkAlaN1VXehmoGm9o7nhSY0uKVVg/vTGDFH39OOQ4ahlSPmf0J7 RxmvHMaDRAWMmn1Ky+Vl/RME945GVXRF4T+A+HimFo/0GTlLhpnmdpNTlrPBAY0N/ziM VJH29KAufBU4ct5em8+6IkoKGxdruBYDPMtqV+0Y1EPkldnsfoIl+fK4VPTugAn4vC0h vYJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=hKI90P9PUUShWQ5+4wQBc7xPIwXEAfQYKEsGh1MpJZs=; b=RcRC+GUHQj1zi7JP9YzirM7/6nHbmfvS1Sp+/bQhpDyNnoAp9WgiF1/IOq5I0IaPfM DnmR7KEWNTC0xdiFeiHrTzqHiMByi3GoQ2E5Z22bOHgv/VTQhMNUvnoLNpwBI+cjS+N+ D6TYx7LdNVKW99ZUhAwoPydCxUH3CevQbS1q23OWmiKDY/9NaBO7DMMbmtrrud9+66lB 6dC1wXCcixgIZAOe+mK2PshGUm1QuTTNxfN0A5I7EvKUXIbv47gZLcBAF/+0OMHpolN7 dFdOocdpkJHdO53PmeYPXAMz+iHhs2nMrNkDNFpmOTr0kQdGpHkLKQA/WnonSjK74GRI qofw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=DTpxaxoB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qc8si1850328ejb.150.2020.06.30.06.58.02; Tue, 30 Jun 2020 06:58:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=DTpxaxoB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387659AbgF3Nyv (ORCPT + 99 others); Tue, 30 Jun 2020 09:54:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730455AbgF3Nyt (ORCPT ); Tue, 30 Jun 2020 09:54:49 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0B21C03E97A for ; Tue, 30 Jun 2020 06:54:49 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id h4so2417448plt.9 for ; Tue, 30 Jun 2020 06:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hKI90P9PUUShWQ5+4wQBc7xPIwXEAfQYKEsGh1MpJZs=; b=DTpxaxoBrlqgFtIm8yAQMb341OyK/ndjEYjXK9tGbhGBwisW4MOxBHZ4AF4FDA/02m FE1IEvNVNRcPVI4EfkzNjyzKc28vzwvcAXCPa48q88z6AfYJyEqtZavoB08GtaqwIFmZ 5msOaC6bHwT4f6NJcL2N48MYAird2/Xlj5iei4yfkZKl2Jgrru0q2OyYJkjRAMbDQ2kB VDXDrxP8KF6sFSMpn3AGotfAimtzX2YLcVXjs0JutM1wEqD7nRFwq0bLMjlwHPYp5odZ e+66w2vtmERdrhz2mTHMd0mWQ0ZRTEcZzcd3acmnQYyNunRekXJ4MMVmPw5lJJ2ybCJv oP4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hKI90P9PUUShWQ5+4wQBc7xPIwXEAfQYKEsGh1MpJZs=; b=lwunbYKziQXkUsU60ZM1sxhHXFy+GSHzZto/Iw5IMtT+9rVewBdMTgX1JRQFbcwQog MbAQ2Wqe3E8GRBdQQ6JzkCNj5OB7qydvQ6pJMToq86wWI6dWDzxPvO6nZSAdBOgm+iKD wkLJs3oV/0Hqde48EG1+EYgsrK05aw5aQQFo7I7no8pjMqckGUShgmuUwsijJxI4dvFj SwIgH8CqBFGfAQs13d6JD3GwiHoNlrhFVH2Jsr/f3xKFrr8wfN46DJ3ME/pV1t5Bgpba BGKQiCu85EszIoTu03AYd5si3eiJVlg/Cx9VO8C+9rqoCB4ZDpVGgTFLPmyCa5bdnKXy AL8Q== X-Gm-Message-State: AOAM533/YDRd02cG1FnqCHpaMPxpBXS7xsvFm7NhuX2JjxJXALAIf5hc M7cE7pUF9V5p8Q7P/NMMQdYzrw== X-Received: by 2002:a17:902:ff0c:: with SMTP id f12mr18122209plj.254.1593525289171; Tue, 30 Jun 2020 06:54:49 -0700 (PDT) Received: from ?IPv6:2605:e000:100e:8c61:4113:50ea:3eb3:a39b? ([2605:e000:100e:8c61:4113:50ea:3eb3:a39b]) by smtp.gmail.com with ESMTPSA id l12sm2722675pff.212.2020.06.30.06.54.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2020 06:54:48 -0700 (PDT) Subject: Re: [PATCH 11/20] fs: remove a weird comment in submit_bh_wbc To: Christoph Hellwig Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org References: <20200629193947.2705954-1-hch@lst.de> <20200629193947.2705954-12-hch@lst.de> From: Jens Axboe Message-ID: <70e8de25-4e26-9c00-1492-e433ebfdbc90@kernel.dk> Date: Tue, 30 Jun 2020 07:54:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200629193947.2705954-12-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/20 1:39 PM, Christoph Hellwig wrote: > All bios can get remapped if submitted to partitions. No need to > comment on that. I'm pretty sure that comment is from me, dating back to when the bio code was introduced in 2001. The point wasn't the remapping, just that from here on down the IO was purely bio based, not buffer_heads. Anyway, totally agree that it should just die, it's not that interesting or useful anymore. -- Jens Axboe