Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3598500ybt; Tue, 30 Jun 2020 06:59:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVY12iiNF2ZQBIaS1Kum4li7cvTtg6B+c1gkCMPdPGxSwI/FRFg8s3H3tSKpvjXpSEEWa0 X-Received: by 2002:aa7:df08:: with SMTP id c8mr22844235edy.372.1593525550342; Tue, 30 Jun 2020 06:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593525550; cv=none; d=google.com; s=arc-20160816; b=Zg8FFYGzZ6T8gGqnFRXxAXdu7ZpUzqA6H2cEMO8BcLVKqzWu2VhkwUfO7mHUF8h0Pb DoIgWM/sTWsQA8qpjDr7URw529de4VTZh6Bmn0yKgnq9dVmRpuu0RQhUyhJ4SZQbWVPs tckCCNttviXmHE770hpC9RCN+a97HEha0/L8dMyJ0Qjfvw8jyQrcCq+OJXCfUfUmYUkw /PjxBAw6v39xxpG+WuJFAefQFTCaJVBnZE8k7EfGQLv1XqzR4BZz6wb+qiCqaGhXeJBJ a4tiXw+aikgWIiDZWR0gBy9R4dg1BAU3xTHO08ssfQXH1DJV0/CHXwT00B3bv/re2wpE 5NvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=6WoGClip/9lIMADlW96b66URAMpf8agavloV0J0+6z0=; b=vta+mQOmY4sZ510ffAkOEuln9AqndVxePbVtvGze8MMJn+zD+RHCjYyIOxL/S/wcVW o8YakdKnFRcnmQJzqgWxh+7M9ySL7Cnhg8AYm5qUQe7g8ihQg0M1Lfb2vBaUbZ0fB/uZ GVs+Dgyp78G4MyUimsEbG+qxLMqP7rwaAKvCxG43YSMSZrvhKeqqYyEsU4HtiLb1BUzw z7b7BnMLmOm0AzWGyiq4VipSPPAin0HSGql349sHwNDnQJsmJ/5Ca9eCCkoqp7Z6mAag xkEgJ32rBfflQ+jpDRcLJMFYeYm0fDMAUjed6B7xrbYnG4AmNxYr2enMPaUGeh3Vhjxq c5ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=NpTXHg4e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm9si2314413ejc.624.2020.06.30.06.58.47; Tue, 30 Jun 2020 06:59:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=NpTXHg4e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732949AbgF3N5e (ORCPT + 99 others); Tue, 30 Jun 2020 09:57:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731327AbgF3N5c (ORCPT ); Tue, 30 Jun 2020 09:57:32 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1E8CC03E979 for ; Tue, 30 Jun 2020 06:57:32 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id j4so8513103plk.3 for ; Tue, 30 Jun 2020 06:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6WoGClip/9lIMADlW96b66URAMpf8agavloV0J0+6z0=; b=NpTXHg4eLKIDB3B017yOQCnwb3dBSkBllVoAHChdp1FGoCyQ19eq1VXevMLSrM/lhD bQk0yrTpC1Irq2MNTGh49jfpD7zqgiVbJtqJYeruoqyJ31uUsOmkXd433JMWP+NtSVov ZzGBWe4xhNJRj47E5aARYY/9uUmyXWiWjg1l6pljN4nXRLoWQN1OJ6HHzWlN6uNS1Lvc bcrSTvkHyH7MDnkYvBu1O0JOQIAWVJgUutILN7WG8Di8qKlewR28Ariy+ojttBxfAl/B FxzoT9uIuyEQaP+UAHq4/tgN7PJVGPmfXaxyS6AW/qEEAuiLEhHfUD+LyDQfCVGwqwpj 3wAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6WoGClip/9lIMADlW96b66URAMpf8agavloV0J0+6z0=; b=KSVR+sqH/JSjQG+TDlDrfSr+EVhrA4RfnL3nLkTytkwgE7HDYLxPK7R8A5ZfUg5lfd vu9M8hqol4rfZDch5AwM9wMMuFiYMyxuRiydDUqZ5Cf8mOIQlcTIOMvF/pg8dY8CklUq Ts4rnCJfMnbBM2K+iW7F6G8A6Pl382c0wfSr3XVtjzOQ7E7bdt8EMGtin91yWjTU+cCr M61zYyM9+AtTX5p8YybGWRqORxiUtQLMnxGo6sU6Vahj07bxEvVYc069T3XZIgdDKbmk VkzaAif07a2vJcsd5k9Q4Nip/ob8ft2kFhPjIngY5UO3PACWx4qoeXwIE9DeSVSjCyhY eneg== X-Gm-Message-State: AOAM5332yqXjJhENs085Sb8N9sBdWoSABz1S/nsYWkPKNx3WyGM5pnde dmWGaD7ulVdyla6VNd1k1bd75A== X-Received: by 2002:a17:90a:ec13:: with SMTP id l19mr20004827pjy.81.1593525452289; Tue, 30 Jun 2020 06:57:32 -0700 (PDT) Received: from ?IPv6:2605:e000:100e:8c61:4113:50ea:3eb3:a39b? ([2605:e000:100e:8c61:4113:50ea:3eb3:a39b]) by smtp.gmail.com with ESMTPSA id m140sm2896019pfd.195.2020.06.30.06.57.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2020 06:57:31 -0700 (PDT) Subject: Re: rename ->make_request_fn and move it to the block_device_operations To: Christoph Hellwig Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org References: <20200629193947.2705954-1-hch@lst.de> From: Jens Axboe Message-ID: Date: Tue, 30 Jun 2020 07:57:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200629193947.2705954-1-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/20 1:39 PM, Christoph Hellwig wrote: > Hi Jens, > > this series moves the make_request_fn method into block_device_operations > with the much more descriptive ->submit_bio name. It then also gives > generic_make_request a more descriptive name, and further optimize the > path to issue to blk-mq, removing the need for the direct_make_request > bypass. Looks good to me, and it's a nice cleanup as well. Applied. -- Jens Axboe