Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v6 2/4] driver core: add deferring probe reason to
 devices_deferred property
To:     Grygorii Strashko <grygorii.strashko@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Jernej Skrabec <jernej.skrabec@siol.net>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Jonas Karlman <jonas@kwiboo.se>, linux-kernel@vger.kernel.org,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        Russell King - ARM Linux <linux@armlinux.org.uk>,
        Neil Armstrong <narmstrong@baylibre.com>,
        andy.shevchenko@gmail.com, Mark Brown <broonie@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
From:   Andrzej Hajda <a.hajda@samsung.com>
Message-ID: <21f5ec9c-2d1d-5f28-5aeb-ac0db144a55e@samsung.com>
Date:   Tue, 30 Jun 2020 17:41:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
        Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <66faa188-5ef6-d449-07fe-28c8be5e559c@ti.com>
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20200626100103.18879-1-a.hajda@samsung.com>
        <CGME20200626100110eucas1p2c5b91f2c98a5c6e5739f5af3207d192e@eucas1p2.samsung.com>
        <20200626100103.18879-3-a.hajda@samsung.com>
        <5f159e00-44fd-515b-dd8c-4db9845dc9e6@ti.com>
        <7e3c924b-c025-a829-6868-78e2935c70eb@samsung.com>
        <66faa188-5ef6-d449-07fe-28c8be5e559c@ti.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 30.06.2020 10:59, Grygorii Strashko wrote:
> Hi
>
> On 29/06/2020 14:28, Andrzej Hajda wrote:
>> Hi Grygorii,
>>
>> (...)
>>
>>>>    /*
>>>>     * deferred_devs_show() - Show the devices in the deferred probe
>>>> pending list.
>>>>     */
>>>> @@ -221,7 +241,8 @@ static int deferred_devs_show(struct seq_file *s,
>>>> void *data)
>>>>        mutex_lock(&deferred_probe_mutex);
>>>>          list_for_each_entry(curr, &deferred_probe_pending_list,
>>>> deferred_probe)
>>>> -        seq_printf(s, "%s\n", dev_name(curr->device));
>>>> +        seq_printf(s, "%s\t%s", dev_name(curr->device),
>>>> + curr->device->p->deferred_probe_reason ?: "\n");
>>>>          mutex_unlock(&deferred_probe_mutex);
>>>>
>>>
>>> Sry, may be i missing smth, but shouldn't it be optional
>>> (CONFIG_DEBUG_FS is probably too generic).
>>>
>>
>> I am not sure what exactly are you referring to, but this patch does not
>> add new property, it just extends functionality of existing one.
>
> Sry, needed to be more specific.
>
> You've added  device_set_deferred_probe_reson(dev, &vaf);
> which expected to be used on every EPROBE_DEFER in dev_err_probe() in 
> combination with
>
> +       } else {
> +               device_set_deferred_probe_reson(dev, &vaf);
>                 dev_dbg(dev, "error %d: %pV", err, &vaf);
>
> ^^ dev_dbg() does not add any runtime overhead during boot unless enabled
> +       }
>
> But:
>
> +void device_set_deferred_probe_reson(const struct device *dev, struct 
> va_format *vaf)
> +{
> +       const char *drv = dev_driver_string(dev);
> +
> +       mutex_lock(&deferred_probe_mutex);
> +
> +       kfree(dev->p->deferred_probe_reason);
> +       dev->p->deferred_probe_reason = kasprintf(GFP_KERNEL, "%s: 
> %pV", drv, vaf);
> +
> +       mutex_unlock(&deferred_probe_mutex);
> +}
>
> ^^ Adds locking, kfree() and kasprintf() for every deferred probe 
> during boot and can't be disabled.
>
> Right?


Right, but usually the burden should be insignificant in comparison to 
probe time, so I do not think it is worth optimizing.


Regards

Andrzej


>
>