Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: (2) [PATCH] fs: fat: add check for dir size in
 fat_calc_dir_size
Reply-To: a.sahrawat@samsung.com
From:   AMIT SAHRAWAT <a.sahrawat@samsung.com>
To:     OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
CC:     Anupam Aggarwal <anupam.al@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <875zb8o6zh.fsf@mail.parknet.co.jp>
Message-ID: <20200630170748epcms5p87fa9b4348c1448d2d5a5f6cdddbc021e@epcms5p8>
Date:   Tue, 30 Jun 2020 22:37:48 +0530
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <875zb8o6zh.fsf@mail.parknet.co.jp>
        <87ftacolpf.fsf@mail.parknet.co.jp>
        <1593428559-13920-1-git-send-email-anupam.al@samsung.com>
        <20200630123355epcms5p602efe0e4ceedcfe11eae2153c8466678@epcms5p6>
        <CGME20200629110320epcas5p34ccccc7c293f077b34b350935c328215@epcms5p8>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=C2=A0=0D=0A>=C2=A0There=C2=A0are=C2=A0many=C2=A0implementation=C2=A0that=
=C2=A0doesn't=C2=A0follow=C2=A0the=C2=A0spec=C2=A0strictly.=C2=A0And=0D=0A>=
=C2=A0when=C2=A0I=C2=A0tested=C2=A0in=C2=A0past,=C2=A0Windows=C2=A0also=C2=
=A0allowed=C2=A0to=C2=A0read=C2=A0the=C2=A0directory=C2=A0beyond=0D=0A>=C2=
=A0that=C2=A0limit.=C2=A0I=C2=A0can't=C2=A0recall=C2=A0though=C2=A0if=C2=A0=
there=C2=A0is=C2=A0in=C2=A0real=C2=A0case=C2=A0or=C2=A0just=C2=A0test=0D=0A=
>=C2=A0case=C2=A0though.=0D=0A>>>=C2=A0Thanks=C2=A0Ogawa,=C2=A0yes=C2=A0the=
re=C2=A0are=C2=A0many=C2=A0implementations,=C2=A0preferably=C2=A0going=C2=
=A0around=C2=A0with=C2=A0different=C2=A0variants.=0D=0A>=C2=A0But,=C2=A0usi=
ng=C2=A0standard=C2=A0linux=C2=A0version=C2=A0on=C2=A0the=C2=A0systems=C2=
=A0and=C2=A0having=C2=A0such=C2=A0USB=C2=A0connected=C2=A0on=C2=A0such=C2=
=A0systems=C2=A0is=C2=A0introducing=C2=A0issues(importantly=C2=A0because=C2=
=A0these=C2=A0being=C2=A0used=C2=A0on=C2=A0Windows=C2=A0also=C2=A0by=C2=A0u=
sers).=0D=0A>=C2=A0I=C2=A0am=C2=A0not=C2=A0sure,=C2=A0if=C2=A0this=C2=A0is=
=C2=A0something=C2=A0which=C2=A0is=C2=A0new=C2=A0from=C2=A0Windows=C2=A0par=
t.=0D=0A>=C2=A0But,=C2=A0surely=C2=A0extending=C2=A0the=C2=A0directory=C2=
=A0beyond=C2=A0limit=C2=A0is=C2=A0causing=C2=A0regression=C2=A0with=C2=A0FA=
T=C2=A0usage=C2=A0on=C2=A0linux.=0D=0A=C2=A0=0D=0Aregression=C2=A0from=C2=
=A0what?=0D=0A=C2=A0=0D=0A>=C2=A0It=C2=A0is=C2=A0making=C2=A0FAT=C2=A0files=
ystem=C2=A0related=C2=A0storage=C2=A0virtually=C2=A0unresponsive=C2=A0for=
=C2=A0minutes=C2=A0in=C2=A0these=C2=A0cases,=0D=0A>=C2=A0and=C2=A0important=
ly=C2=A0keep=C2=A0on=C2=A0putting=C2=A0pressure=C2=A0on=C2=A0memory=C2=A0du=
e=C2=A0to=C2=A0increasing=C2=A0buffer=C2=A0heads=C2=A0(already=C2=A0a=C2=A0=
known=C2=A0one=C2=A0with=C2=A0FAT=C2=A0fs).=0D=0A=C2=A0=0D=0AI'm=C2=A0confu=
sed.=C2=A0What=C2=A0happen=C2=A0actually?=C2=A0Now=C2=A0looks=C2=A0like=C2=
=A0you=C2=A0are=C2=A0saying=C2=A0the=0D=0Aissue=C2=A0is=C2=A0extending=C2=
=A0size=C2=A0beyond=C2=A0limit.=C2=A0But=C2=A0previously=C2=A0it=C2=A0said=
=C2=A0the=C2=A0corruption.=0D=0A=C2=A0=0D=0AAre=C2=A0you=C2=A0saying=C2=A0=
=22beyond=C2=A0that=C2=A0limit=22=C2=A0is=C2=A0the=C2=A0fs=C2=A0corruption?=
=0D=0A=C2=A0=0D=0AI.e.=C2=A0did=C2=A0you=C2=A0met=C2=A0real=C2=A0directory=
=C2=A0corruption?=C2=A0or=C2=A0you=C2=A0are=C2=A0trying=C2=A0to=C2=A0limit=
=0D=0Abecause=C2=A0slowness=C2=A0on=C2=A0big=C2=A0directory?=0D=0A>>>=20Wil=
l=20try=20to=20arrange=20the=20fsck/chkdsk=20output=20for=20the=20related=
=20to=20disk,=20to=20highlight=20the=20concerns.=0D=0A=0D=0A=C2=A0=0D=0A>=
=C2=A0So=C2=A0if=C2=A0there=C2=A0is=C2=A0no=C2=A0strong=C2=A0reason=C2=A0to=
=C2=A0apply=C2=A0the=C2=A0limit,=C2=A0I=C2=A0don't=C2=A0think=C2=A0it=C2=A0=
is=0D=0A>=C2=A0good=C2=A0to=C2=A0limit=C2=A0it.=C2=A0=0D=0A>>>=C2=A0The=C2=
=A0reason=C2=A0for=C2=A0us=C2=A0to=C2=A0share=C2=A0this=C2=A0is=C2=A0becaus=
e=C2=A0of=C2=A0the=C2=A0unresponsive=C2=A0behaviour=C2=A0observed=C2=A0with=
=C2=A0FAT=C2=A0fs=C2=A0on=C2=A0our=C2=A0systems.=0D=0A>=C2=A0This=C2=A0is=
=C2=A0not=C2=A0a=C2=A0new=C2=A0issue,=C2=A0we=C2=A0have=C2=A0been=C2=A0obse=
rving=C2=A0this=C2=A0for=C2=A0quite=C2=A0sometime=C2=A0(may=C2=A0be=C2=A0ar=
ound=C2=A01year+).=0D=0A>=C2=A0Finally,=C2=A0we=C2=A0got=C2=A0hold=C2=A0of=
=C2=A0disk=C2=A0which=C2=A0is=C2=A0making=C2=A0this=C2=A0100%=C2=A0reproduc=
ible.=0D=0A>=C2=A0We=C2=A0thought=C2=A0of=C2=A0applying=C2=A0this=C2=A0to=
=C2=A0the=C2=A0mainline,=C2=A0as=C2=A0our=C2=A0FAT=C2=A0is=C2=A0aligned=C2=
=A0with=C2=A0main=C2=A0kernel.=0D=0A=C2=A0=0D=0ASo=C2=A0what=C2=A0was=C2=A0=
the=C2=A0root=C2=A0cause=C2=A0of=C2=A0slowness=C2=A0on=C2=A0big=C2=A0direct=
ory?=0D=0A>>>=20Root=20cause=20was=20the=20continous=20FAT=20chain=20walk=
=20through=20for=20that=20directory=20and=20making=20the=20corresponding=20=
applications=20to=20stuck.=0D=0AIt=20keeps=20going=20on,=20so=20eventually=
=20the=20application=20had=20to=20be=20terminated.=0D=0AMay=20be=20arraning=
=20corresponding=20metadata=20dump=20related=20with=20this=20might=20help=
=20in=20clearing=20doubts.=0D=0AI=20Hope=20to=20arrange=20them=20soon.=0D=
=0A=C2=A0=0D=0AThanks.=0D=0A--=C2=A0=0D=0AOGAWA=C2=A0Hirofumi=C2=A0<hirofum=
i=40mail.parknet.co.jp>=0D=0A=C2=A0