Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp44041ybt; Tue, 30 Jun 2020 14:26:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrN3X4HE3YcT207bfr3/1GoQem6jbu9sYgabqj6FTFFZSM1opPPXs/mPajNI8R7MCVz/S9 X-Received: by 2002:a50:fa0c:: with SMTP id b12mr25909255edq.226.1593551961416; Tue, 30 Jun 2020 14:19:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593551961; cv=none; d=google.com; s=arc-20160816; b=aVnxxoKyjI3j0SpXZebglKd7E+N4WGhZL5c/2hr/SXqE6mxkpeH7W5uZ8E+pL/ifyX Xw7yiwhL5KTC/SWZxSYOObD6to7FlzOuN7Xwp1vSPc35/JOaR2rvCiGtnDzdkmiudVJg qdSR4wyjFsvmdhIp1cv1HTs8T9yKniUNvfXUX63o8Pv1BZvadRE/XBO26dG366ZXpjUT vSEF1z7IcPxF9uTWJxBZ01huVVh/HkmjU81ZwPJWTpz+bow0SilmU0sRCPz0EI32Pxub JY4Jeg6iaQ4XA4+FV/k1Zf5tAuMQX6tUCUP3xrXAl2o8YnxmN2GB3JKMriWrOo1AvZFM fLjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=zBgO4FtqBMVvCqnGKaWURsIb6uOxAylErpdeGJFRJ7k=; b=It2kniNZa4wbaz/HL0dMIbRYIRGHPwLhzLqsqGfuRUNbVLhCUqbkDHhmoaY95UT6wD 557/7upnz5WR6MX8Lixs8lZUtCm3szRLo3AsyfczhJwPqZgwfCNc0B+Z7gycFkbeHl1u wP3AKr7ZJZb7ZVN8uxtVRlQZakefOj2U88XwA2F7sg7AZmMB3Qpg+XOUZPoplXX7VvYx ILenea/+RO2hP1xGXku2CUr13eW2K9s30sTPCIpmMffyAgoWtpcJ8ktEKW/ZL8PEl0ua a5wMRcgVK6vLCtUhxD94InqWvtPKkbXnXWDw5PogbsIIL/z1CmBSeBNJsoH3UUnNayjA IHPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c102si2719345edf.216.2020.06.30.14.18.58; Tue, 30 Jun 2020 14:19:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729576AbgF3UhO (ORCPT + 99 others); Tue, 30 Jun 2020 16:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgF3UhO (ORCPT ); Tue, 30 Jun 2020 16:37:14 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF7C8C061755; Tue, 30 Jun 2020 13:37:13 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EC9631277ED77; Tue, 30 Jun 2020 13:37:12 -0700 (PDT) Date: Tue, 30 Jun 2020 13:37:12 -0700 (PDT) Message-Id: <20200630.133712.641790280086952744.davem@davemloft.net> To: colin.king@canonical.com Cc: borisp@mellanox.com, aviadye@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net, kuba@kernel.org, tariqt@mellanox.com, saeedm@mellanox.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net/tls: fix sign extension issue when left shifting u16 value From: David Miller In-Reply-To: <20200630142746.516188-1-colin.king@canonical.com> References: <20200630142746.516188-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Jun 2020 13:37:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 30 Jun 2020 15:27:46 +0100 > From: Colin Ian King > > Left shifting the u16 value promotes it to a int and then it > gets sign extended to a u64. If len << 16 is greater than 0x7fffffff > then the upper bits get set to 1 because of the implicit sign extension. > Fix this by casting len to u64 before shifting it. > > Addresses-Coverity: ("integer handling issues") > Fixes: ed9b7646b06a ("net/tls: Add asynchronous resync") > Signed-off-by: Colin Ian King Applied, thanks Colin.