Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp47639ybt; Tue, 30 Jun 2020 14:31:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOKgmpHy7C9mNEdC6UlORb1977ZmAF2IO0FkmoY+jZgBt5Q0yuYV15pg9J8mo3iS6fjBWw X-Received: by 2002:a17:906:1414:: with SMTP id p20mr19500542ejc.247.1593552336532; Tue, 30 Jun 2020 14:25:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593552336; cv=none; d=google.com; s=arc-20160816; b=vQxt1djQw2TS6cED9ol4GKPstsIghs83Tv4Y8EDCqUeiTaXDV1WyXAotxr/zmK5EzW 8yYqRmPpQOyOjm1Rpo1lKlGZcg0a/+bP6ATt1R2++08MqBumNhRv7w5SwNwg+aHfUqlc s5PxUUxuvVhhheWLHJUZ5TQgEiLBdbhJ4bkaLZFWN3/97IwOGEp1FsBtUpwTuNlWTJzr 1Qkw668LUEs/YQuvkG0XIiWSQe5ctkRjdc460q26g11s+o1mWOmJ3xtsb9xkChkrDyJb DJH5VsfCkq9tu5ExShMreI1ddYnBll/GOVOc8t/g+FcbbvBl6NZGT5fS6kCMoz3+Gd7b k+lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Fwe4KS31zOssjRVGh+gZr2fKp9aGzSGpeXe9/8E0WbQ=; b=IFzkAcjyiwBu9xyWKWNeR/zfICwZvYQIAvDjnp1Z0bv7WALohHmaNOD6mFjf4t/t07 9enJ/8iuu8RVO3eb3s+CWDJvic0InFTxwI+4ypkT8YOdPjHtlqIPrqos5iAchGIyB0Wn ZoYGiL1CwZyX5YB1SWXKoM3NdwV+xUj+MuJGCW5qcrlmNxEuec5+0+0Ec5rWaQ95rz4Z DGQlE9lAn2IFYW2DUIahi9hkLyN0aEy4iLdfYuoRWpe2kckwSkqB8Xr5mxz8P+6hWXv3 JDn/Swuglu7NrRd3lv2dmmVGebUU8YxRH2jqcQsooB+DGRuOXI3Jd9OS4uuK9omK99Pe 05wA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r8si2309922ejs.462.2020.06.30.14.25.12; Tue, 30 Jun 2020 14:25:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729825AbgF3UjA (ORCPT + 99 others); Tue, 30 Jun 2020 16:39:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729341AbgF3Ui7 (ORCPT ); Tue, 30 Jun 2020 16:38:59 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3957C061755; Tue, 30 Jun 2020 13:38:59 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 571841277F862; Tue, 30 Jun 2020 13:38:59 -0700 (PDT) Date: Tue, 30 Jun 2020 13:38:58 -0700 (PDT) Message-Id: <20200630.133858.836154523537769936.davem@davemloft.net> To: colin.king@canonical.com Cc: borisp@mellanox.com, saeedm@mellanox.com, leon@kernel.org, kuba@kernel.org, tariqt@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net/mlx5e: fix memory leak of tls From: David Miller In-Reply-To: <20200630151646.517757-1-colin.king@canonical.com> References: <20200630151646.517757-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Jun 2020 13:38:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 30 Jun 2020 16:16:46 +0100 > From: Colin Ian King > > The error return path when create_singlethread_workqueue fails currently > does not kfree tls and leads to a memory leak. Fix this by kfree'ing > tls before returning -ENOMEM. > > Addresses-Coverity: ("Resource leak") > Fixes: 1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support") > Signed-off-by: Colin Ian King Applied, thanks.