Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200625075805.363918-1-mans0n@gorani.run> <CAMpxmJXDHX-U-HWR8093orBU1ZxEeWp_r2Xar+k5FMoZ1pS78Q@mail.gmail.com>
 <CAHp75VdNh8nFNqZxSD0g7ADD8GvY+Dmbfg8xc6LW94hw_Brwew@mail.gmail.com> <c7fd2365-0f47-b2c8-4085-020928c79254@gorani.run>
In-Reply-To: <c7fd2365-0f47-b2c8-4085-020928c79254@gorani.run>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 1 Jul 2020 00:23:48 +0300
Message-ID: <CAHp75VcA-kmJHyuZOMs-BDqhQ7FszZti=uHmSs-NCH2F6e_c4A@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570
To:     Sungbo Eo <mans0n@gorani.run>
Cc:     Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 30, 2020 at 7:11 PM Sungbo Eo <mans0n@gorani.run> wrote:
>
> Thanks for all the reviews! I've updated the patch, please have a look.
>
> And I have something to ask.
>
> # echo 1 > gpio408/value
> # cat gpio408/value
> cat: read error: I/O error
> # cat gpio408/direction
> out
> # echo out > gpio408/direction
> # echo in > gpio408/direction
> [   91.006691] gpio-408 (sysfs): gpiod_direction_input: missing get()
> but have direction_input()
> ash: write error: I/O error
>
> I've never dealt with GPO expander before, so this seems a bit odd to me.
> Is it perfectly okay to leave get() and direction_input() unimplemented?

Actually it would be better to return the value you set for output in ->get().


-- 
With Best Regards,
Andy Shevchenko