Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp74923ybt; Tue, 30 Jun 2020 15:08:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvp+P98GdijcVnYZsgVzU2rj6kEhU6Y2Sx7cJWdu8QInVDERHTjECUMYW1+r33tbJxcZlr X-Received: by 2002:a50:acc5:: with SMTP id x63mr3801612edc.99.1593554506846; Tue, 30 Jun 2020 15:01:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593554506; cv=none; d=google.com; s=arc-20160816; b=FqCWPR9+UJHhEmk1GqTj58A7+z2cQpzU2TxIw6TegL5ylKdMMX+SZ2MGHMItO5RVuI 6vzn/2y7+tS0mnhUE2jZXWZgvl3zDuHc2sAJFqJZexppwTv3XxcxuZiSAWNDNZzBD4+r 9ErlaZyQpSUE8ScJLu/N5OvU01nH2PIVv7g3EiKE0GgMJ1MRrXHu2GdV2l9ENZ00jq0K ZmbEKYRno91pE3ffiByxC47lA4/DnfIkw04ngYwkftHEBhx5qk+1T75z6j6DVluEJqmr Owrxil2M4OXb3H6EbfU7y7dj0NZ/aoCGoaao9r5VJrkeG9zmtSFm02mSFnrG7Vdqf9W3 5Enw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:dkim-signature:dkim-filter; bh=dzOtmJ7mD/siyGoPxQC/+AbiDTyc52D1unXi3sYhHw4=; b=rBSpkFKwD1pgsUI2VTXmGD29eghDoDctLI6D4WVOjyEeGV7fb89vIH9L6FPQOBI+6O JYdXlbXIquRjDPl4w1uKY7t1FRCnvDhgYwZt5NectpdBgUOcO3rl439rjjTZ1GClBWx9 RlAIsWrp5WXnpHp/7hGXYKReDYwm4rWjRxWYgEfUh9AA4bIP53V5667ZOq/nkfw8r6Ku 8BFldlHhSCNRtekSqLsCuIxnSbG5qEavI+HxuynjoxKJ5GLpzIprDvZ2oW93zG/FAhGb uSeG368BN0aeesIsL6MBOTwu/ADxLA15wzqeHXPzxo61NOd8bIdwX0/ltSf4XHZxUCiR aaBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@efficios.com header.s=default header.b=BMWsT4ae; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g26si1656209ejo.47.2020.06.30.15.01.23; Tue, 30 Jun 2020 15:01:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@efficios.com header.s=default header.b=BMWsT4ae; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729381AbgF3VRs (ORCPT + 99 others); Tue, 30 Jun 2020 17:17:48 -0400 Received: from mail.efficios.com ([167.114.26.124]:48592 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgF3VRs (ORCPT ); Tue, 30 Jun 2020 17:17:48 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 125932C72E3; Tue, 30 Jun 2020 17:17:47 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id dX8LJcERVS4j; Tue, 30 Jun 2020 17:17:46 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id B14522C7393; Tue, 30 Jun 2020 17:17:46 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com B14522C7393 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1593551866; bh=dzOtmJ7mD/siyGoPxQC/+AbiDTyc52D1unXi3sYhHw4=; h=Date:From:To:Message-ID:MIME-Version; b=BMWsT4ae0NFCJ7Ar9Wj/SDYypbB4SF4CqanRW+dwWOnP+GK8ukFotA8/0X3ZNkB/T 1V95PFBjmkA5EYmVmvP3OKlTGV7mLADFG4gJ62Nm2NV4PQCGiBWaRktNCvUmZlckwu r7ZWl5ZhfWVO8a3kcgf9YovcOjsHZ/HYtGUAxThOmKOvsnsmtBlN5hz8RRoNR3zdEv MolT2QWCjHCKHUoyJkeBtPOXhn2r+G4/sT+OaxU3KE9i4psxZ02NjnPLQuBJST3H5f jIU1V9zvvQyWxBuezPLl8Tv38IGeQlrelEw8V7iNEUrUu2Vwtjs9kTtUP8j00T3SMb tuMOsYxVkRlEw== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RjPVrSqWHdX1; Tue, 30 Jun 2020 17:17:46 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 9DE582C71DC; Tue, 30 Jun 2020 17:17:46 -0400 (EDT) Date: Tue, 30 Jun 2020 17:17:46 -0400 (EDT) From: Mathieu Desnoyers To: Eric Dumazet Cc: "David S. Miller" , Linus Torvalds , linux-kernel , netdev , Yuchung Cheng , Jonathan Rajotte-Julien Message-ID: <474095696.17969.1593551866537.JavaMail.zimbra@efficios.com> In-Reply-To: References: <312079189.17903.1593549293094.JavaMail.zimbra@efficios.com> <20200630.134429.1590957032456466647.davem@davemloft.net> Subject: Re: [regression] TCP_MD5SIG on established sockets MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_3945 (ZimbraWebClient - FF77 (Linux)/8.8.15_GA_3928) Thread-Topic: TCP_MD5SIG on established sockets Thread-Index: bT5tgAuCnz/dlB46lWW2qWJ3mIXuLQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Jun 30, 2020, at 4:56 PM, Eric Dumazet edumazet@google.com wrote: > On Tue, Jun 30, 2020 at 1:44 PM David Miller wrote: >> >> From: Eric Dumazet >> Date: Tue, 30 Jun 2020 13:39:27 -0700 >> >> > The (C) & (B) case are certainly doable. >> > >> > A) case is more complex, I have no idea of breakages of various TCP >> > stacks if a flow got SACK >> > at some point (in 3WHS) but suddenly becomes Reno. >> >> I agree that C and B are the easiest to implement without having to >> add complicated code to handle various negotiated TCP option >> scenerios. >> >> It does seem to be that some entities do A, or did I misread your >> behavioral analysis of various implementations Mathieu? >> >> Thanks. > > Yes, another question about Mathieu cases is do determine the behavior > of all these stacks vs : > SACK option > TCP TS option. I will ask my customer's networking team to investigate these behaviors, which will allow me to prepare a thorough reply to the questions raised by Eric and David. I expect to have an answer within 2-3 weeks at most. Thank you! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com