Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp108926ybt; Tue, 30 Jun 2020 15:54:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5k5w4zVTPrdnqGVEZ2pTRC4MEGFzKx1LdVNrzNDPCX03cyDIxIBJSkrBg4kqhetoPEjXV X-Received: by 2002:a17:906:f2d6:: with SMTP id gz22mr19920528ejb.407.1593557659674; Tue, 30 Jun 2020 15:54:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593557659; cv=none; d=google.com; s=arc-20160816; b=Hg2j4e4q6S3m4LxaPBwysIj6ARVW+CDjaAuSib+iTDOTtcpwGjeq1IjqEchGPiI0tP cFdtmeVFiPz8uW99wjEvXMamzsCmS478AZQE2YmX5WmSzjJUpKfPyHO3PwzK9WAZqnUR O+SFBdNeSILw7GA5pchZGruj2nVniLi2sHV3C0rUI/wFaSxbTTBsIqctsYH028AXX+aa Y4SZFXm/2jPegN4OoD5t62/dyAimGfsPZkRHOsSy4Qpw5GRjnfs5nVI4fr4gKaaTZ2Ud nPEUTHQji6UAMP6519xMoT8cE5TVVzzoaJpvNnEtoqNLiW05ce7W/RD2c53kmBEhmOIl q9fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=VxicbTfqxnoTtFMqWRV++azPEgQNYh4z4heZOD/0YrM=; b=SNiFE+OboSzdqflQfVC+iiVVI9gGcV3ShsdUlo40X189lomlLfkfoSxNrkciI64L4I gW/o9naPVKQElwNhdlq4RBjVCKTsQGEgeJO1nbkvRX6DwXisy3K9ARJ+1783kPphuk2I 0tVwhBmmEivLZ1FolLfvR1vLS7Gu4QgcTunbE7h4D4ZzLUBD2Ax6W320xD7HaZ5TKU70 T1vH6QLNTK9O5AJmCFUXjW389YV14W90TmmQV1V2E4lts6Fke7mbvJb16fVPvBNepziJ h1aEXcT53rY2fQNYhnbvSgNM0xycfL61CTVwNdzCbxqj0nEXvKzU5S5fgBcgUM+lUCd1 z//w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr11si3272551ejc.254.2020.06.30.15.53.56; Tue, 30 Jun 2020 15:54:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726410AbgF3Wxr (ORCPT + 99 others); Tue, 30 Jun 2020 18:53:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbgF3Wxq (ORCPT ); Tue, 30 Jun 2020 18:53:46 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9862C061755; Tue, 30 Jun 2020 15:53:46 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EEF29127BE1BD; Tue, 30 Jun 2020 15:53:45 -0700 (PDT) Date: Tue, 30 Jun 2020 15:53:45 -0700 (PDT) Message-Id: <20200630.155345.921284251457806411.davem@davemloft.net> To: liheng40@huawei.com Cc: vishal@chelsio.com, kuba@kernel.org, hariprasad@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: cxgb4: fix return error value in t4_prep_fw From: David Miller In-Reply-To: <1593427791-41194-1-git-send-email-liheng40@huawei.com> References: <1593427791-41194-1-git-send-email-liheng40@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Jun 2020 15:53:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li Heng Date: Mon, 29 Jun 2020 18:49:51 +0800 > t4_prep_fw goto bye tag with positive return value when something > bad happened and which can not free resource in adap_init0. > so fix it to return negative value. > > Fixes: 16e47624e76b ("cxgb4: Add new scheme to update T4/T5 firmware") > Reported-by: Hulk Robot > Signed-off-by: Li Heng Applied, thank you.