Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbWC3LRE (ORCPT ); Thu, 30 Mar 2006 06:17:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932179AbWC3LRE (ORCPT ); Thu, 30 Mar 2006 06:17:04 -0500 Received: from smtp.osdl.org ([65.172.181.4]:50910 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932177AbWC3LRD (ORCPT ); Thu, 30 Mar 2006 06:17:03 -0500 Date: Thu, 30 Mar 2006 03:16:43 -0800 From: Andrew Morton To: Jens Axboe Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org Subject: Re: [PATCH] splice support #2 Message-Id: <20060330031643.028a28de.akpm@osdl.org> In-Reply-To: <20060330102419.GU13476@suse.de> References: <20060330100630.GT13476@suse.de> <20060330021644.7f7c5282.akpm@osdl.org> <20060330102419.GU13476@suse.de> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 28 Jens Axboe wrote: > > > > +static void *page_cache_pipe_buf_map(struct file *file, > > > + struct pipe_inode_info *info, > > > + struct pipe_buffer *buf) > > > +{ > > > + struct page *page = buf->page; > > > + > > > + lock_page(page); > > > + > > > + if (!PageUptodate(page)) { > > > > || page->mapping == NULL > > Fixed Actually that wasn't right. If the page was truncated then we shouldn't return -EIO to userspace. We should return zero, as this is the first page. Which means either returning an ERR_PTR here for -EIO or re-checking i_size in the caller. Maybe the latter? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/