Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: [PATCH v4 3/5] scsi: ufs: Introduce HPB module
Reply-To: daejun7.park@samsung.com
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sang-yoon Oh <sangyoon.oh@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Adel Choi <adel.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <SN6PR04MB4640A27B0DCB321B165D59F0FC6F0@SN6PR04MB4640.namprd04.prod.outlook.com>
Message-ID: <1087081975.11593562201594.JavaMail.epsvc@epcpadp1>
Date:   Wed, 01 Jul 2020 09:07:57 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
References: <SN6PR04MB4640A27B0DCB321B165D59F0FC6F0@SN6PR04MB4640.namprd04.prod.outlook.com>
        <963815509.21593413582881.JavaMail.epsvc@epcpadp2>
        <1239183618.61593413402991.JavaMail.epsvc@epcpadp1>
        <231786897.01593413281727.JavaMail.epsvc@epcpadp2>
        <1239183618.61593413882377.JavaMail.epsvc@epcpadp2>
        <CGME20200629064323epcms2p787baba58a416fef7fdd3927f8da701da@epcms2p3>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Avri,

> +static int ufshpb_get_dev_info(struct ufs_hba *hba,
> > +                              struct ufshpb_dev_info *hpb_dev_info,
> > +                              u8 *desc_buf)
> > +{
> > +       int ret;
> > +       int version;
> > +       u8 hpb_mode;
> Maybe before doing anything, first verify that all descriptors are in the proper size?

Before reading descriptor, ufshcd_map_desc_id_to_length() may check descriptor size.
So I deleted size checking codes.

static int ufshpb_read_desc(struct ufs_hba *hba, u8 desc_id, u8 desc_index,    
                          u8 selector, u8 *desc_buf)                           
{                                                                              
        int err = 0;                                                           
        int size;                                                              
                                                                               
  ->    ufshcd_map_desc_id_to_length(hba, desc_id, &size);                     
                                                                               
        pm_runtime_get_sync(hba->dev);                                         
                                                                               
        err = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,  
                                            desc_id, desc_index,               
                                            selector,                          
                                            desc_buf, &size);  


> > +#define UFSHPB_WRITE_BUFFER_ID                 0x02
> Should be 0x01 for HPB1.0

OK.

Thanks,
Daejun