Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Peter Chen <peter.chen@nxp.com>,
        =?utf-8?Q?Micha=C5=82_Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP
In-Reply-To: <AM7PR04MB715735B54F24293ABF7B37908B8C0@AM7PR04MB7157.eurprd04.prod.outlook.com>
References: <237e4bc8c63680f9ce0388d35b4c34a856ed8595.1590690518.git.mirq-linux@rere.qmqm.pl> <20200529081104.GD32755@b29397-desktop> <20200529135524.GA14614@qmqm.qmqm.pl> <AM7PR04MB715735B54F24293ABF7B37908B8C0@AM7PR04MB7157.eurprd04.prod.outlook.com>
Date:   Wed, 01 Jul 2020 09:53:54 +0300
Message-ID: <87zh8j7mkd.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Peter Chen <peter.chen@nxp.com> writes:

>=20=20
>> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, =
unsigned
>> intf, unsigned alt)
>> > >  	/* we know alt =3D=3D 0, so this is an activation or a reset */
>> > >
>> > >  	if (intf =3D=3D acm->ctrl_id) {
>> > > -		dev_vdbg(&cdev->gadget->dev,
>> > > -				"reset acm control interface %d\n", intf);
>> > > -		usb_ep_disable(acm->notify);
>> > > +		if (acm->notify->enabled) {
>> > > +			dev_vdbg(&cdev->gadget->dev,
>> > > +					"reset acm control interface %d\n", intf);
>> > > +			usb_ep_disable(acm->notify);
>> > > +		}
>> >
>> > But it does not fix any issues, the usb_ep_disable checks 'enabled' fl=
ag.
>>=20
>> It generates spurious trace events if you enable them.
>>=20
>
> You mean the trace events from core.c? If it is, we could try to improve =
it
> and indicate it is already enabled or disabled.

I agree :-)

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl78MwIACgkQzL64meEa
mQaEhA/9FX2Rt90P2cv0yV8OH6+R6yinveawhOOllasJKyZZ8AiPo/63DpV3Yq/M
b7MkdyqExd0OTZTZ5fEeBRE/P8QoMpUYFfztAzM6jE6mz+Vun42B6xgPf0D5w8AP
OQGV2ZBBPoPNzTTA+3mYY8sUevKSWfFTl2srrQSYEvmQMWzlXuMZn1deUsSEf3e8
JLi7SvgFEhqMS2Er/1LoHF++zZSlMQFUir0rNoLdaSX6Cp7TwMGmwm6Dt9MOlByz
sXvBR4mC8LY0iA5NyR0BVl0D4RUwPG9BxyXDOIJ8sGeIVvkrPz0omUUf+6y9uzlf
r/VJk9wOKBbuoosSalYUo50SxSYvReNxMbAENuXf6S3yJ4iq1/71xKBKcr0pkyzi
CXhbJJhXCKGOAWyZV7tM+n6sRDdpLIB7/qcTxKsZOGcBGb7qoydcpVKYu8f+yUq/
nu23yRjbGzeL5QwcP6ZsO+s1H+CE9o7pLizKIdSHEhVbMg1dkWKdwr8uJRbb8mjY
2NKVm+I7iNGOZDQtOgkmHi1FascF5+Qfe3H/E/qbFgnuIQGyiDzozoRk9xYzR+Hq
1WrKXPbdIWienJA1H/ecshyKd7tUm0nzRqeNZnsXrucHbjliHxWEUvuqGN7Vh2NZ
o1K8X7QOScZeCEY1TquXDuKylONHyzzuXTVsFLc3XZrekQ0I6nU=
=R+dN
-----END PGP SIGNATURE-----
--=-=-=--