Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     =?utf-8?Q?Micha=C5=82_Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>,
        Peter Chen <peter.chen@nxp.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP
In-Reply-To: <20200530171552.GC16333@qmqm.qmqm.pl>
References: <237e4bc8c63680f9ce0388d35b4c34a856ed8595.1590690518.git.mirq-linux@rere.qmqm.pl> <20200529081104.GD32755@b29397-desktop> <20200529135524.GA14614@qmqm.qmqm.pl> <AM7PR04MB715735B54F24293ABF7B37908B8C0@AM7PR04MB7157.eurprd04.prod.outlook.com> <20200530171552.GC16333@qmqm.qmqm.pl>
Date:   Wed, 01 Jul 2020 09:54:42 +0300
Message-ID: <87wo3n7mj1.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qmqm.pl> writes:

> On Sat, May 30, 2020 at 01:03:17AM +0000, Peter Chen wrote:
>>=20=20
>> > > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f=
, unsigned
>> > intf, unsigned alt)
>> > > >  	/* we know alt =3D=3D 0, so this is an activation or a reset */
>> > > >
>> > > >  	if (intf =3D=3D acm->ctrl_id) {
>> > > > -		dev_vdbg(&cdev->gadget->dev,
>> > > > -				"reset acm control interface %d\n", intf);
>> > > > -		usb_ep_disable(acm->notify);
>> > > > +		if (acm->notify->enabled) {
>> > > > +			dev_vdbg(&cdev->gadget->dev,
>> > > > +					"reset acm control interface %d\n", intf);
>> > > > +			usb_ep_disable(acm->notify);
>> > > > +		}
>> > >
>> > > But it does not fix any issues, the usb_ep_disable checks 'enabled' =
flag.
>> >=20
>> > It generates spurious trace events if you enable them.
>> You mean the trace events from core.c? If it is, we could try to improve=
 it
>> and indicate it is already enabled or disabled.
>
> It is indicated in return code, but the problem is that this generates
> noise and wastes debugging time. The problem I was seeing manifested
> itself as disabling disabled EPs and desync of EP state between core
> and UDC driver. The patch avoids the noise and makes the code obvious.
> (This check was there at some point in time, BTW.)

I agree with this as well. But still, $subject doesn't look like a
candidate for the -rc :-) I'll apply it for the next merge window.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl78MzIACgkQzL64meEa
mQb8NxAAyEILBMyca53t6KeP5XmYc8AkhP7RVNnTUtfSNQ+bPLieCmLtvZUKs9kc
EiNjRyA0PXt29gHQW/7D0v03XpDuoSiylB44SIEN9MHZd9QkOoGSjWs4jjGncHnG
trFiTOUuX5JzHhdOH+1LFLesqief/3gh86rkyVjQ1ElY7T5greNX+oIah+nwFUuF
zIv5jxEWUjbZII2rZcwU2LluXP8tA9R/Dcj4nF25AfiZQ3Mpz3UiFvPTt5J0WV0h
qJNFICg1c1K232YTfzjvFLm9mUjiU4xMQweQDpRM88fHXkmHMsJ3e8aSH5r6SC81
rF9Lfu9CacE/goGwLGb1GCj62OU+K7vyXUiwOyFdVOGtYQEzIR3lDbVRL7OKrOeO
W9Ex7jVteGrtsSy3gWK+KQKj0f0A7lOwVvJwi47qnKYiKjsXTROxt3zKc52T0Jou
3HG3SZS7lBcym8UlMfEvXaiqPaOZAYn7v8bVsWrFEPd6DC33nflX+jmY/J8xrfLD
MQSe7fHR2amTfJdyNq7uFRBav51aeHGa12Pp6fy4V6Cqrb0tqSPvBf1XJ6+k4Rkh
qxW58jgs3gV2Qcj3CMjP8mLr/Or82TwCeCjmAY19JMbmrWsMJo0ZlG/AaFE1PB/K
CzsRtWTC2YlOPTeW48FpwKY+BfmnykUKzOSisg7eXP3T/kSmtv8=
=xfht
-----END PGP SIGNATURE-----
--=-=-=--