Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Philippe Schenker <philippe.schenker@toradex.com>
CC:     Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Stefan Agner <stefan.agner@toradex.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: chipidea: fix ci_irq for role-switching use-case
Thread-Topic: [PATCH] usb: chipidea: fix ci_irq for role-switching use-case
Thread-Index: AQHWS6lrNGtWbd2boEmTo3bADIlBSqjvNguAgAAr6YCAAPWjgIAAvP+AgAD5YgCAAF78AIAACJcA
Date:   Wed, 1 Jul 2020 09:02:43 +0000
Message-ID: <20200701090305.GB22478@b29397-desktop>
References: <20200626110311.221596-1-philippe.schenker@toradex.com>
 <20200629072703.GC30684@b29397-desktop>
 <88f0a5bf564eded8b210457204facdf2c7a9c5dc.camel@toradex.com>
 <20200630004323.GA12443@b29397-desktop>
 <7ee055810cb7c4a06bf978f3d443c908f237c006.camel@toradex.com>
 <20200701025223.GA11041@b29397-desktop>
 <b5c61ae5f17b74624c1e2e4b08fc2fdcd1fb53f6.camel@toradex.com>
In-Reply-To: <b5c61ae5f17b74624c1e2e4b08fc2fdcd1fb53f6.camel@toradex.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F0E516AD2A453E49B4AA27B5A50A6285@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 238eae92-91e9-46a4-d6aa-08d81d9d842e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 09:02:43.6583
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zgtIqpoH7IKCTCCe6GlJnxhazGMWb7d88IxSPhYH70gCl6PMo5DvFN1ZlozLoGsM1HWqFYt4ClP17+zTD4/zGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4246
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-07-01 08:32:22, Philippe Schenker wrote:
> On Wed, 2020-07-01 at 02:52 +0000, Peter Chen wrote:
> > On 20-06-30 11:59:49, Philippe Schenker wrote:
> > > On Tue, 2020-06-30 at 00:43 +0000, Peter Chen wrote:
> > > > On 20-06-29 10:04:13, Philippe Schenker wrote:
> > > > > On Mon, 2020-06-29 at 07:26 +0000, Peter Chen wrote:
> > > > > > On 20-06-26 13:03:11, Philippe Schenker wrote:
> > > > > > > If the hardware is in low-power-mode and one plugs in device
> > > > > > > or
> > > > > > > host
> > > > > > > it did not switch the mode due to the early exit out of the
> > > > > > > interrupt.
> > > > > >=20
> > > > > > Do you mean there is no coming call for role-switch? Could you
> > > > > > please
> > > > > > share
> > > > > > your dts changes? Try below patch:
> > > > >=20
> > > > > Here are my DTS changes:
> > > > >=20
> > > > > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
> > > > > b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
> > > > > index 97601375f2640..c424f707a1afa 100644
> > > > > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
> > > > > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi
> > > > > @@ -13,6 +13,13 @@
> > > > >                 stdout-path =3D "serial0:115200n8";
> > > > >         };
> > > > > =20
> > > > > +       extcon_usbc_det: usbc_det {
> > > > > +               compatible =3D "linux,extcon-usb-gpio";
> > > > > +               id-gpio =3D <&gpio7 14 GPIO_ACTIVE_HIGH>;
> > > > > +               pinctrl-names =3D "default";
> > > > > +               pinctrl-0 =3D <&pinctrl_usbc_det>;
> > > > > +       };
> > > > > +
> > > > >         /* fixed crystal dedicated to mpc258x */
> > > > >         clk16m: clk16m {
> > > > >                 compatible =3D "fixed-clock";
> > > > > @@ -174,6 +181,7 @@
> > > > >  };
> > > > > =20
> > > > >  &usbotg1 {
> > > > > +       extcon =3D <&extcon_usbc_det>, <&extcon_usbc_det>;
> > > >=20
> > > > If you have only ID extcon, but no VBUS extcon, you only need to
> > > > add only phandle, see dt-binding for detail please.
> > >=20
> > > You where right again! Thanks, this actually solves the RNDIS issue
> > > for
> > > our colibri-imx7 board:
> > >=20
> > > +       extcon =3D <0>, <&extcon_usbc_det>;
> > >=20
> > > Howevever on this iMX7 board we have VBUS hooked up to the SoC,
> > > that's
> > > why it works only with ID.
> > >=20
> > > On Colibri-iMX6ULL we do not have VBUS hooked up.
> >=20
> > So, there is no any events for connecting to Host? If it is, the
> > workaround for this board is disable runtime pm. And you only need to
> > write one extcon phandle for ID since you have external event for ID,
> > but no event for VBUS. ID event is not the same with VBUS, for
> > example,
> > if you plug cable into host, you will not get the ID event, you could
> > only get VBUS event if there is an event (eg, through GPIO) for it.
> >=20
> > Peter
>=20
> No we don't have extra Host events. We have one GPIO, if it is high USB
> should be in gadget mode and if the GPIO is low USB should be in host
> mode.
>=20
> Is there no way we can achieve this on mainline without disabling
> runtime PM?
>=20

At least I think so, since you don't have any events to let the
SW know you connects to host if the controller is in low power mode.

Peter

> Philippe
>=20
> >=20
> > > So device/host
> > > switching works only with 'extcon =3D <&extcon_usbc_det>,
> > > <&extcon_usbc_det>;' but then RNDIS and also a normal thumb-drive
> > > does
> > > not work. How could I work around this fact? A dummy-gpio that would
> > > always read "high" for vbus would be a solution for me.
> > >=20
> > > Philippe
> > >=20

--=20

Thanks,
Peter Chen=