Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp460638ybt; Wed, 1 Jul 2020 02:41:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/dFvpUi1sdZNYoOItgCGKWDBEWFKO/FYgc/mv+mSZ3FYxTcv682MiIt6Or14ddHWlhEUt X-Received: by 2002:a17:906:191a:: with SMTP id a26mr23052739eje.315.1593596475912; Wed, 01 Jul 2020 02:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593596475; cv=none; d=google.com; s=arc-20160816; b=IIvggB45QRbK0XClYTJMIwYGCdROzS29B4/EcdDp3ARbcP6F5K8aPGoPdWrJwjZY8i MYOeWriZa3C/2ZJBmLsTsARWcKVyVHWlVfYTTaCDsukQ696EYSTx0N1m6qql4oVxFFAr /TnQ1DD9aw+2FcL3EXnPzrpO8mHT6M3Inq+jxsxTRjxTfjyD9+++pDyQ/CqQpDw36e1Y fMd8EdZnFLY6Ro/iSI/cp1a8Y56ymi2tiWxShGr34De5KymeZsuGDiWdcY/XLx4ggy6m IkSKVURbcTxo0nC+QjPc4nV2mZlCPggbxA7vD3yObLoeJ0a9IXpqXx96vIxGBGmjNkKG yC7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=MorucHa9nBed5fLXu0DZwYTjk+q02wEEEoCleXnOD3w=; b=pRKkb+QmoncQd+6di/fI1cMv3So0hR86tpFmaB5s6d9+q+R4799ro7BF69lJ2M3fYe W7a5uW3ADh+QBgVnKRUJTK/cw3FG2zwQpi06qTJEJsfDRjNUF0+FgONLLZMgFyuntzer Svm8Tjgg504KPn+eQtmVVgWHILg+qwYfBCUaWWOP90h/UanOe+sp39lowNIXvm5Vy4sC IYIkTzaIWfybMjnHN4auC1GmlDjb5mzQaQBOHpc2dEooZjvXHG5AYF75iLKiUE9VWlwC xAMI8V9/3hPiVOIT1js0GTIaaDvwb2KjFdzCizd3wCpuCt3FMe8nIWg4pjZ9+BwDm7ZL egyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i4si3500987eja.4.2020.07.01.02.40.52; Wed, 01 Jul 2020 02:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729339AbgGAJko (ORCPT + 99 others); Wed, 1 Jul 2020 05:40:44 -0400 Received: from mail.loongson.cn ([114.242.206.163]:34516 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729267AbgGAJkn (ORCPT ); Wed, 1 Jul 2020 05:40:43 -0400 Received: from [10.130.0.52] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxT2gQWvxeT6FNAA--.1580S3; Wed, 01 Jul 2020 17:40:32 +0800 (CST) Subject: Re: [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Tony Lindgren , linux-omap@vger.kernel.org References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-12-git-send-email-yangtiezhu@loongson.cn> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Tiezhu Yang Message-ID: <25e52567-bda4-e936-f04b-8126eb849520@loongson.cn> Date: Wed, 1 Jul 2020 17:40:32 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf9DxT2gQWvxeT6FNAA--.1580S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYs7k0a2IF6FyUM7kC6x804xWl14x267AK xVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGw A2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26ryj 6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26F 4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAa Y2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4 A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI 62AI1cAE67vIY487MxkIecxEwVAFwVW8uwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6Fyj6rWU JwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcS sGvfC2KfnxnUUI43ZEXa7IU8Ntx3UUUUU== X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2020 05:14 PM, Markus Elfring wrote: >> In the function omap_init_irq_of(), system resource "omap_irq_base" >> was not released in the error case, fix it. > Another small wording adjustment: > … in an error case. Thus add a call of the function “iounmap” > in the if branch. OK, thank you, I will do it in v5 of this patch #11 and next patch #12. > > Regards, > Markus