Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-13-git-send-email-yangtiezhu@loongson.cn>
In-Reply-To: <1593569786-11500-13-git-send-email-yangtiezhu@loongson.cn>
From:   Anup Patel <anup@brainfault.org>
Date:   Wed, 1 Jul 2020 15:13:31 +0530
Message-ID: <CAAhSdy3e-qHSqQkVtps-D2Qz+GK28XyNVFbXAqKDWvxcioYCuw@mail.gmail.com>
Subject: Re: [PATCH v4 12/14] irqchip/riscv-intc: Fix potential resource leak
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <maz@kernel.org>,
        "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>,
        Markus Elfring <Markus.Elfring@web.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 1, 2020 at 7:47 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> In the function riscv_intc_init(), system resource "intc_domain"
> was not released in the error case, fix it.
>
> Fixes: 6b7ce8927b5a ("irqchip: RISC-V per-HART local interrupt controller driver")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  drivers/irqchip/irq-riscv-intc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c
> index a6f97fa..8d6286c 100644
> --- a/drivers/irqchip/irq-riscv-intc.c
> +++ b/drivers/irqchip/irq-riscv-intc.c
> @@ -122,6 +122,7 @@ static int __init riscv_intc_init(struct device_node *node,
>         rc = set_handle_irq(&riscv_intc_irq);
>         if (rc) {
>                 pr_err("failed to set irq handler\n");
> +               irq_domain_remove(intc_domain);
>                 return rc;
>         }
>
> --
> 2.1.0
>

Looks good to me.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup