Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 1 Jul 2020 07:48:43 -0700
From:   Tony Lindgren <tony@atomide.com>
To:     Drew Fustini <drew@beagleboard.org>
Cc:     Rob Herring <robh+dt@kernel.org>, bcousson@baylibre.com,
        linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Jason Kridner <jkridner@beagleboard.org>,
        Robert Nelson <robertcnelson@gmail.com>,
        "H . Nikolaus Schaller" <hns@goldelico.com>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] ARM: dts: am335x-pocketbeagle: set default mux for
 gpio pins
Message-ID: <20200701144843.GI37466@atomide.com>
References: <20200628152442.322593-1-drew@beagleboard.org>
 <20200629170358.GT37466@atomide.com>
 <20200630020102.GA45128@x1>
 <20200630182037.GF37466@atomide.com>
 <20200630213155.GA115731@x1>
 <20200630213423.GG37466@atomide.com>
 <20200630214231.GA116238@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200630214231.GA116238@x1>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Drew Fustini <drew@beagleboard.org> [200630 21:43]:
> On Tue, Jun 30, 2020 at 02:34:23PM -0700, Tony Lindgren wrote:
> > * Drew Fustini <drew@beagleboard.org> [200630 21:32]:
> > > On Tue, Jun 30, 2020 at 11:20:37AM -0700, Tony Lindgren wrote:
> > ...
> > > > > > Needing to change the dts does not sound good to me.. But maybe you mean
> > > > > > this is needed until the gpio-omap and pinctrl-single patches are merged?
> > > > >
> > > > > I agree that I would like for userspace to be able to do run-time
> > > > > changes.  However, I think something would need to be added to the
> > > > > pinconf support in pinctrl-single for that to be possible.  There are
> > > > > bias properties but non for receiver enable.
> > > > > 
> > > > > Does it seem sensible to add that?
> > > > 
> > > > Well let's see with Linus W says. To me it seems this might be a good
> > > > reason to allow a sysfs interface to change the pinctrl if we don't
> > > > have it yet? With the proper gpio line naming it should be quite simple
> > > > to use too :)
> > > 
> > > I think if pinctrl-single allowed mux to be set through debugfs that
> > > could be one solution to the use case of users prototyping with a
> > > beaglebone.  Maybe that could be acceptable?
> > 
> > I think this should not depend on debugfs though, it should be a
> > generic interface.
> 
> Ok, thanks.  I'm trying to imagine a solution as there no existing
> pinctrl uAPI.  gpiod uAPI has gained some pinctrl functionality with
> the work that Kent Gibson has been doing beyond just bias flags.

OK. Yeah sounds like in this case toggling pinctrl receiver enable
should happen automatically with gpio changes.

> Do you think trying to plumb this through gpio-omap is a reasonable
> approach?

I think any sysfs interface to update pinctrl settings should be
generic to the pinctrl framework. But maybe making it work via gpio
use would do the trick.

Regards,

Tony