Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp724918ybt; Wed, 1 Jul 2020 08:34:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFPYdfTw2Ya5vF2Dh6hMYzQVlSc2+DalJmIeW42wBKl+/S9fquFlMmbUdguMuxC6wZO9q9 X-Received: by 2002:a17:906:aac1:: with SMTP id kt1mr24774294ejb.408.1593617649631; Wed, 01 Jul 2020 08:34:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593617649; cv=none; d=google.com; s=arc-20160816; b=a6Pz3YAwEvKhlnarB2PdT/Zsn8I4x4rilO9Vj7gP3gdOzFhbXmMNttNHo+yTwRlnE0 GKARQm4lMr/8smCevftHaX9HwA1zayWQKvNcGb96NSvFlTubN1FGzgWpkaRp0O0c1wx7 rcQu623+6xbBBQ5E8+5fWvltdNcDY8nldvIvSzlnvXQ5X0WNLP5GA2wbm4fWQ75DgSgA mGgyQjBt3aH3nNIRheNAsy6Xz2kneBo/v7iMSuvWwWRelfSrAJ73CzDLwvtQhhjCnhbt /NqJ4MAHMAbtaltkSoJ+I8XxUKkpnjc81PCDIHadOeEc14KfOytYGo8m1MPG8ZgnBLqV 1V8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=U9tcBWqanEmcG7y4KnRT6hQjOymIY+744WxQv0Dj8Zo=; b=IyXFOwbyx6SkC1aKLm05pXsQg15Dp2yP+m285OhlHSwbxiurzRVFCXuEpeilpzzqJt eSrmy9FhnQz9DCx0pjbBr+JZhThrn72U6XSEYqv5Q6P+jRbys2qBqHnJ+Fe64hnX0cyf bizX999NcClkSBJtfnXdysifN5MVjT63uG8c9b/O8W4IBQCDmFtLebnuixjeDJx7cTx8 ldaaButcwSyS0BHPVIFGFRfHgCErWhdSANVRGyBqEa5mwbVEVVZrDpTSZlsI/ZNdfEu2 zF8pKH21KJ9UEtNdVX5qnAbp5HWcxV7sUFBO8+JliPnQ2QFRlChUeNwFyorV8zEUBEU8 ngow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=K1hFqpY0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id co20si3954624edb.131.2020.07.01.08.33.45; Wed, 01 Jul 2020 08:34:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=K1hFqpY0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731820AbgGAPdd (ORCPT + 99 others); Wed, 1 Jul 2020 11:33:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731645AbgGAPdc (ORCPT ); Wed, 1 Jul 2020 11:33:32 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE8BFC08C5C1 for ; Wed, 1 Jul 2020 08:33:32 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id t6so11910038pgq.1 for ; Wed, 01 Jul 2020 08:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=U9tcBWqanEmcG7y4KnRT6hQjOymIY+744WxQv0Dj8Zo=; b=K1hFqpY0Fmcq2Wbi/vJnWw4/HMuvHGfUuInJqu3Ga3uSw6z4rCdqHlaAlLOUwojT7r qgAU4kYVt+OIY/65Ibv7i+8Bf4nZFSPnMsfMGpFUaMCURJtiG7GN2g7WCIWZL3Nv+cQD CS3lKkwI4V/2nIHY0n4JaqAxwXj2MNrnu1kWV1+B0N1SJ7t4m3F6NVzqGwbsDLvH8dZ7 iKGcrKRQK/FZDHFlQa6Pb6c6Rzx701nSm3E2U1caDR0qVQWjyS/Z39C9D8p4lImzO9Q2 T/NF09gb/mY9vDwIrBlgZeHNY24isRLRkFdd3/oRXTZuwBRNDYag8IFBNOr77AzCF523 QiLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=U9tcBWqanEmcG7y4KnRT6hQjOymIY+744WxQv0Dj8Zo=; b=E+E58iemVe2AxuGULB6G9IL4dfqqFrAJ02zf9XApBAQPgWcW9f4v9FIx64O73W/AiJ FprRsg/BNrxGGS9j/1COPQhSW9vTn0NRk7UllKyd3tvBHwvTfvWEJoT4TpgkZ/bOYlTB 1iWqLeyyPU07DMGYRIh1kAH7KaQXOjUOi+uL4zjfJZrdLBCyU32DEVd1vla2hZ4H24Ce etB9JpSu1nnAoKLgte02/1ii7KL6Ox7wJeaUtezSv0wbRJfMWOl+PUVsFsCHIQTbarF6 x3l4wRkwYYFTX1w0LLIJILzYRMF7cP++rKzK9izgDQraT8j9YG35NJNQ0k5iwdf1hXVq 88rw== X-Gm-Message-State: AOAM530Aj7BiHTuz/735LCYtT58VVcfbriRCMiFuSRbUm5qnlR/YbgEF Mz0pTiJvPRRoQ6e5ZQQF1UYo87tH X-Received: by 2002:a63:580c:: with SMTP id m12mr19822599pgb.446.1593617612304; Wed, 01 Jul 2020 08:33:32 -0700 (PDT) Received: from localhost.localdomain ([61.83.141.141]) by smtp.gmail.com with ESMTPSA id a9sm6566763pfr.103.2020.07.01.08.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 08:33:31 -0700 (PDT) From: Sidong Yang To: Rodrigo Siqueira Cc: Sidong Yang , Emil Velikov , Haneen Mohammed , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail Date: Wed, 1 Jul 2020 15:31:34 +0000 Message-Id: <20200701153134.4187-1-realwakka@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org there is an error when igt test is run continuously. vkms_atomic_commit_tail() need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of vblank events. without this code, next atomic commit will not enable vblank and raise timeout error. Signed-off-by: Sidong Yang --- drivers/gpu/drm/vkms/vkms_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 1e8b2169d834..10b9be67a068 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -93,6 +93,8 @@ static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state) flush_work(&vkms_state->composer_work); } + drm_atomic_helper_wait_for_vblanks(dev, old_state); + drm_atomic_helper_cleanup_planes(dev, old_state); } -- 2.17.1